This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/2289/

src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py (Diff revision 1)
def cim_method_addpassphrase(self, env, object_name,
434
        except CryptoError:
433
        except:

Don't use bare except:, it catches all exception like KeyboardInterrupt.

Use at least except Exception.


src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py (Diff revision 1)
def cim_method_deletepassphrase(self, env, object_name,
486
        except CryptoError:
485
        except:

Same as above.


- Radek Novacek


On March 18th, 2015, 10 a.m. CET, Jan Safranek wrote:

Review request for OpenLMI Developers.
By Jan Safranek.

Updated March 18, 2015, 10 a.m.

Repository: openlmi-storage

Description

Fixed "cannot import name CryptoError" on Fedora 23.

Blivet no longer defines this exception.

Diffs

  • src/lmi/storage/LMI_ExtentEncryptionConfigurationService.py (cd8fd1b1f0bd2c8d5e466ee5679800dc39ad324d)

View Diff