This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1699/

I tried to compile full openlmi-providers.spec, here is first bunch of issues. I'll go through source code later.


README (Diff revision 3)
134
    - dhash-devel

This is IMO not needed.


openlmi-providers.spec (Diff revision 3)
577
%if ! 0%{with_fan}

s/with_fan/wish_sssd ?


openlmi-providers.spec (Diff revision 3)
641
%if 0%{?with_realmd}
667
%if 0%{?with_realmd}
642
    realmd \
668
    realmd \
643
%endif
669
%endif

add sssd to the loop in similar way to install sssd-doc


src/sssd/utils.h (Diff revision 3)
24
#include <openlmi/openlmi.h>

You should probably use:

include "openlmi.h"

There is no openlmi/openlmi.h when openlmi-providers are compiled in mock.


- Jan Safranek


On červen 3rd, 2014, 1:24 odp. CEST, Pavel BÅ™ezina wrote:

Review request for OpenLMI Developers.
By Pavel Březina.

Updated Čer. 3, 2014, 1:24 odp.

Repository: openlmi-providers

Description

This is the OpenLMI SSSD provider.

It is yet dependent on an unreleased version of SSSD and even on patches that are not present in SSSD master branch. We are slowly reviewing and push these patches to the master. In the mean time, please use the SSSD from my repository, branch #openlmi:

http://fedorapeople.org/cgit/pbrezina/public_git/sssd.git/log/?h=openlmi

The IFP service has to be enabled in SSSD for the provider to be able to communicate with the daemon.

Diffs

  • CMakeLists.txt (bcea09707d1d87db374cf6561d00a19258b54b3b)
  • README (9e7a7abce940c3dea55e0d2a6cf6daed315e8361)
  • doc/admin/CMakeLists.txt (96e7616e2af807d99b4afe7af81571367e15f286)
  • doc/admin/sssd/index.rst (PRE-CREATION)
  • mof/60_LMI_SSSD.mof (PRE-CREATION)
  • mof/CMakeLists.txt (cbc971b1baa3b9400c644f7abdfc0c272bbabf65)
  • openlmi-providers.spec (dc975d5f0fd169d49227b3749e0fa3f96e5184f9)
  • src/CMakeLists.txt (e0fbb4e05236fc10164f359b5a13f6406aacbda1)
  • src/sssd/90_LMI_SSSD_Profile.mof.skel (PRE-CREATION)
  • src/sssd/CMakeLists.txt (PRE-CREATION)
  • src/sssd/LMI_HostedSSSDServiceProvider.c (PRE-CREATION)
  • src/sssd/LMI_SSSDAvailableComponentProvider.c (PRE-CREATION)
  • src/sssd/LMI_SSSDAvailableDomainProvider.c (PRE-CREATION)
  • src/sssd/LMI_SSSDBackendDomainProvider.c (PRE-CREATION)
  • src/sssd/LMI_SSSDBackendProvider.c (PRE-CREATION)
  • src/sssd/LMI_SSSDBackendProviderProvider.c (PRE-CREATION)
  • src/sssd/LMI_SSSDComponentProvider.c (PRE-CREATION)
  • src/sssd/LMI_SSSDDomainProvider.c (PRE-CREATION)
  • src/sssd/LMI_SSSDDomainSubdomainProvider.c (PRE-CREATION)
  • src/sssd/LMI_SSSDMonitorProvider.c (PRE-CREATION)
  • src/sssd/LMI_SSSDProviderProvider.c (PRE-CREATION)
  • src/sssd/LMI_SSSDResponderProvider.c (PRE-CREATION)
  • src/sssd/LMI_SSSDServiceProvider.c (PRE-CREATION)
  • src/sssd/cmpiLMI_SSSD-cimprovagt (PRE-CREATION)
  • src/sssd/sssd_components.h (PRE-CREATION)
  • src/sssd/sssd_components.c (PRE-CREATION)
  • src/sssd/sssd_domains.h (PRE-CREATION)
  • src/sssd/sssd_domains.c (PRE-CREATION)
  • src/sssd/utils.h (PRE-CREATION)
  • src/sssd/utils.c (PRE-CREATION)

View Diff