This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1483/

src/hardware/test/TestHardware.py (Diff revision 1)
45
        self.assertEqual(len(cpu_instances), len(cpu_info))
File "/home/pschiffe/Public/openlmi/openlmi-providers (copy)/src/hardware/test/TestHardware.py", line 45, in test_processor_flags_x86
    self.assertEqual(len(cpu_instances), len(cpu_info))
AssertionError: 1 != 4

src/hardware/test/TestHardware.py (Diff revision 1)
183
        self.assertEqual(sorted(lmi_pci_bridges), sorted(pci_bridges))
File "/home/pschiffe/Public/openlmi/openlmi-providers (copy)/src/hardware/test/TestHardware.py", line 183, in test_pci_bridges
    self.assertEqual(sorted(lmi_pci_bridges), sorted(pci_bridges))
AssertionError: Lists differ: [(u'00:00.0', 340L, 6L, 32902L... != [('00:00.0', 340, 6, 32902, 'I...

First differing element 1:
(u'00:1c.0', 7696L, 6L, 32902L, u'Intel Corporation', u'7 Series/C210 Series Chipset Family PCI Express Root Port 1', None, None, None)
('00:1c.0', 7696, 6, 32902, 'Intel Corporation', '7 Series/C210 Series Chipset Family PCI Express Root Port 1', 8694, 6058, 'Lenovo')

Diff is 1949 characters long. Set self.maxDiff to None to see it.

src/hardware/test/TestHardwareBase.py (Diff revision 1)
72
                value = line.strip().split(':')[1].strip()
  File "/home/pschiffe/Public/openlmi/openlmi-providers (copy)/src/hardware/test/TestHardware.py", line 137, in test_baseboard_basic_info
    baseboards = self.get_baseboards()
  File "/home/pschiffe/Public/openlmi/openlmi-providers (copy)/src/hardware/test/TestHardwareBase.py", line 410, in get_baseboards
    dmidecode_boards = self.parse_dmi_output(self.get_dmi_output(2))
  File "/home/pschiffe/Public/openlmi/openlmi-providers (copy)/src/hardware/test/TestHardwareBase.py", line 72, in parse_dmi_output
    value = line.strip().split(':')[1].strip()
IndexError: list index out of range


$ sudo dmidecode -t 2
[sudo] password for pschiffe: 
# dmidecode 2.12
SMBIOS 2.7 present.

Handle 0x000E, DMI type 2, 15 bytes
Base Board Information
	Manufacturer: LENOVO
	Product Name: 2429BP3
	Version: Not Defined
	Serial Number: 1ZSF33542T2
	Asset Tag: Not Available
	Features:
		Board is a hosting board
		Board is replaceable
	Location In Chassis: Not Available
	Chassis Handle: 0x0000
	Type: Motherboard
	Contained Object Handles: 0

src/hardware/test/TestHardwareBase.py (Diff revision 1)
386
                int(module.get("Speed", "0 MHz".split(" ")[0]))
  File "/home/pschiffe/Public/openlmi/openlmi-providers (copy)/src/hardware/test/TestHardware.py", line 107, in test_physical_memory
    phymems = self.get_physical_memory()
  File "/home/pschiffe/Public/openlmi/openlmi-providers (copy)/src/hardware/test/TestHardwareBase.py", line 386, in get_physical_memory
    int(module.get("Speed", "0 MHz".split(" ")[0]))
ValueError: invalid literal for int() with base 10: '1600 MHz'


$ sudo dmidecode -t 17
# dmidecode 2.12
SMBIOS 2.7 present.

Handle 0x0008, DMI type 17, 34 bytes
Memory Device
	Array Handle: 0x0007
	Error Information Handle: Not Provided
	Total Width: 64 bits
	Data Width: 64 bits
	Size: 8192 MB
	Form Factor: SODIMM
	Set: None
	Locator: ChannelA-DIMM0
	Bank Locator: BANK 0
	Type: DDR3
	Type Detail: Synchronous
	Speed: 1600 MHz
	Manufacturer: Samsung
	Serial Number: 12DCC9C0
	Asset Tag: None
	Part Number: M471B1G73BH0-CK0  
	Rank: Unknown
	Configured Clock Speed: 1600 MHz

Handle 0x0009, DMI type 17, 34 bytes
Memory Device
	Array Handle: 0x0007
	Error Information Handle: Not Provided
	Total Width: 64 bits
	Data Width: 64 bits
	Size: 4096 MB
	Form Factor: SODIMM
	Set: None
	Locator: ChannelB-DIMM0
	Bank Locator: BANK 2
	Type: DDR3
	Type Detail: Synchronous
	Speed: 1600 MHz
	Manufacturer: Hynix/Hyundai
	Serial Number: 0D33DB7E
	Asset Tag: None
	Part Number: HMT351S6CFR8C-PB  
	Rank: Unknown
	Configured Clock Speed: 1600 MHz

src/hardware/test/TestHardwareBase.py (Diff revision 1)
430
        f = open ("%s/%s/%s" % ("/sys/bus/pci/devices/", device, attr_p), "r")
You'll have here /sys/bus/pci/devices//foo/bar.

I think better is:
open ("/sys/bus/pci/devices/%s/%s" % (device, attr_p), "r")

- Peter Schiffer


On January 23rd, 2014, 12:40 p.m. CET, Robin Hack wrote:

Review request for OpenLMI Developers.
By Robin Hack.

Updated Jan. 23, 2014, 12:40 p.m.

Repository: openlmi-providers

Description

Hardware: Upstream testsuite from QA.

Diffs

  • src/hardware/test/README (PRE-CREATION)
  • src/hardware/test/TestHardware.py (PRE-CREATION)
  • src/hardware/test/TestHardwareBase.py (PRE-CREATION)

View Diff