This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/854/

src/account/test/testAccount.py (Diff revision 8)
def test_create_modify_user_in_loop_bz1001490(self):
88
            user = lams1.CreateAccount(Name=myuser, System=cs1)
88
            user = lams1.CreateAccount(Name=myuser, System=cs1)
User really exists after this call?
Assert missing.

src/account/test/testAccount.py (Diff revision 8)
def test_create_modify_user_in_loop_bz1001490(self):
101
            user = self.conn.root.cimv2.LMI_Account.first_instance({"Name":myuser})
101
            user_del = self.conn.root.cimv2.LMI_Account.first_instance({"Name":myuser})
102
            user.delete()
102
            user_del.delete()
103
            self.assertFalse(user_exists(myuser))
103
            self.assertFalse(user_exists(myuser))
104
104
105
            # delete group
105
            # delete group
106
            group = self.conn.root.cimv2.LMI_Group.first_instance({"Name":myuser})
106
            group_del = self.conn.root.cimv2.LMI_Group.first_instance({"Name":myuser})
107
            group.delete()
107
            group_del.delete()
We need separate test case for deleteing user and group... because we need map this cases to tcms when test will be parametrized.

src/account/test/testAccount.py (Diff revision 8)
def test_create_modify_user_in_loop_bz1001490(self):
127
        self.assertEqual(field_in_passwd(user.name,6),myshell)
128
        self.assertEqual(field_in_passwd(user_mod.name,6),myshell)
128
        self.assertEqual(field_in_passwd(user.name,5),myhome)
129
        self.assertEqual(field_in_passwd(user_mod.name,5),myhome)
What is this magic numbers?

- Robin Hack


On September 16th, 2013, 7:27 a.m. UTC, Robin Hack wrote:

Review request for OpenLMI Developers.
By Robin Hack.

Updated Sept. 16, 2013, 7:27 a.m.

Repository: openlmi-providers

Description

Account: Added QA test for account provider.

Diffs

  • src/account/test/testAccount.py (PRE-CREATION)

View Diff