This is an automatically generated e-mail. To reply, visit:

Ok, if we base the model on systemd-localed API, the API concept is not that bad. Unfortunately, what may be good enough for DBus service is not good enough for supported remote API. We need better descriptions of all properties and method parameters. Most of them are just 'string', without any clue, what are possible/allowed values and where to get more docs.

Link to authoritative documentation might be enough here, if there _is_ such documentation in the first place.

mof/60_LMI_Locale.mof (Diff revision 1)
    string Locale[];
I really don't like magic array of strings, individual properties would be much better.

mof/60_LMI_Locale.mof (Diff revision 1)
    string VConsoleKeymap;
What values it can have? What is format of this string?

(this applies to all string properties)

mof/60_LMI_Locale.mof (Diff revision 1)
        string Locale[]);
use individual parameters instead of list of list of strings.

mof/60_LMI_Locale.mof (Diff revision 1)
        string Keymap,
What are expected values of the parameter?

(this applies to all string parameters)

- Jan Safranek

On September 10th, 2013, 12:34 p.m. CEST, Vitezslav Crhonek wrote:

Review request for OpenLMI Developers.
By Vitezslav Crhonek.

Updated Sept. 10, 2013, 12:34 p.m.

Repository: openlmi-providers


New provider: Locale


  • CMakeLists.txt (c5a5c7c8fd1b24f76c4953e8a3cc8257bbe58d8e)
  • README (a80a1d2624c80367ed53e06f50804ed39b3103da)
  • mof/60_LMI_Locale.mof (PRE-CREATION)
  • openlmi-providers.spec (6e75e6f8332df807be4c2c5260211fce3339db89)
  • src/CMakeLists.txt (27bd416e1545725af0975e806975ca2119b4388b)
  • src/locale/CMakeLists.txt (PRE-CREATION)
  • src/locale/LMI_LocaleProvider.c (PRE-CREATION)
  • src/locale/localed.h (PRE-CREATION)
  • src/locale/localed.c (PRE-CREATION)

View Diff