-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/#review1800
-----------------------------------------------------------
Autoscan finished with errors:
Error: SIZEOF_MISMATCH (CWE-398):
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:402:
suspicious_sizeof: Passing argument "output" of type "char *" and
argument "8 /* sizeof (output) */" to function "service_find_all(char *,
int)" is suspicious.
Error: CLANG_WARNING:
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416:24: warning:
Call to 'malloc' has an allocation size of 0 bytes
# si->signal_proxy = malloc(si->slist->cnt * sizeof(GDBusProxy *));
# ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416:
returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416: var_assigned:
Assigning: "si->signal_proxy" = null return value from
"malloc(size_t)".
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:430: dereference:
Dereferencing a null pointer "si->signal_proxy".
Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416:
returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416: var_assigned:
Assigning: "si->signal_proxy" = null return value from
"malloc(size_t)".
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:453: dereference:
Dereferencing a pointer that might be null "si->signal_proxy" when calling
"ind_destroy(ServiceIndication *)".
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:529:9: deref_parm:
Directly dereferencing parameter "si->signal_proxy".
Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416:
returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416: var_assigned:
Assigning: "si->signal_proxy" = null return value from
"malloc(size_t)".
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:448: dereference:
Dereferencing a pointer that might be null "si->signal_proxy" when calling
"ind_destroy(ServiceIndication *)".
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:529:9: deref_parm:
Directly dereferencing parameter "si->signal_proxy".
Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416:
returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:416: var_assigned:
Assigning: "si->signal_proxy" = null return value from
"malloc(size_t)".
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:424: dereference:
Dereferencing a pointer that might be null "si->signal_proxy" when calling
"ind_destroy(ServiceIndication *)".
openlmi-providers-0.4.1_62_g4d87f52/src/service-dbus/util/serviceutil.c:529:9: deref_parm:
Directly dereferencing parameter "si->signal_proxy".
Scanned reviews: 1289
- scanbot
On Nov. 26, 2013, 9:58 a.m., Vitezslav Crhonek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1289/
-----------------------------------------------------------
(Updated Nov. 26, 2013, 9:58 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Service: Support indications on instance property modification.
Diffs
-----
mof/60_LMI_Service.mof 1a86fec8462402d5f5b5ff4f2661596dca470433
src/service-dbus/CMakeLists.txt 3cc2082ac2b28660b854c5e81a3eb581bac8efb5
src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c PRE-CREATION
src/service-dbus/util/serviceutil.h fbdadad5be2d37920407783d806d36af476d62cb
src/service-dbus/util/serviceutil.c 50b18b91cd3083a821a6a3be5f682aafc509be3d
Diff:
http://reviewboard-openlmi.rhcloud.com/r/1289/diff/
Testing
-------
Thanks,
Vitezslav Crhonek