This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1934/

On červenec 25th, 2014, 1:06 odp. UTC, Peter Schiffer wrote:

src/software-dbus/sw-utils.c (Diff revision 1)
void get_pk_repo(const char *repo_id_p, PkRepoDetail **repo_p, char *error_msg,
1004
            if (!enabled)
1005
                continue;

Missing possiblity of listing disabled repos.

Good catch!


On červenec 25th, 2014, 1:06 odp. UTC, Peter Schiffer wrote:

src/software-dbus/sw-utils.c (Diff revision 1)
void get_pk_repo(const char *repo_id_p, PkRepoDetail **repo_p, char *error_msg,
1011
    g_ptr_array_ref(array);
1012
    *garray = array;

Why 2 lines instead of 1? This looks to me less intuitive.

Thanks for noticing.


- Michal


On červenec 25th, 2014, 12:44 odp. UTC, Michal Minar wrote:

Review request for OpenLMI Developers.
By Michal Minar.

Updated Čec. 25, 2014, 12:44 odp.

Repository: openlmi-providers

Description

software-dbus: enhanced repository listing functions

Allow to filter repositories by their state (enabled/disabled).

Diffs

  • src/software-dbus/LMI_HostedSoftwareIdentityResourceProvider.c (ed0a44f8c24ba26211fbf4aa0d420852967bb011)
  • src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c (731c5c902e033cc3ec91acf652e739d1b6c26c85)
  • src/software-dbus/LMI_SoftwareIdentityResourceProvider.c (607660e80ba3b27a2d28be61a8aee8ebea6cbea6)
  • src/software-dbus/sw-utils.h (8ce90ba240097c05db8f9b083aae01147ab21c5f)
  • src/software-dbus/sw-utils.c (211f669539e1086fa8235d7dac3d6f3df26b4034)

View Diff