This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1934/ |
On červenec 25th, 2014, 1:06 odp. UTC, Peter Schiffer wrote:
src/software-dbus/sw-utils.c (Diff revision 1) void get_pk_repo(const char *repo_id_p, PkRepoDetail **repo_p, char *error_msg,1004 if (!enabled)1005 continue;Missing possiblity of listing disabled repos.
Good catch!
On červenec 25th, 2014, 1:06 odp. UTC, Peter Schiffer wrote:
src/software-dbus/sw-utils.c (Diff revision 1) void get_pk_repo(const char *repo_id_p, PkRepoDetail **repo_p, char *error_msg,1011 g_ptr_array_ref(array);1012 *garray = array;Why 2 lines instead of 1? This looks to me less intuitive.
Thanks for noticing.
- Michal
On červenec 25th, 2014, 12:44 odp. UTC, Michal Minar wrote:
Review request for OpenLMI Developers.
By Michal Minar.
Updated Čec. 25, 2014, 12:44 odp.
Repository:
openlmi-providers
Description
Diffs
|