This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1315/

On December 2nd, 2013, 8:52 a.m. UTC, Michal Minar wrote:

cli/lmi/shell/LMIConnection.py (Diff revision 2)
def connect(uri, username="", password="", **kwargs):
158
            logger.error("Not connected, wrong username/password or certificate")
I'd mention the uri in question. It may be run from script where multiple connections come into play.

(this applies to other info and error messages as well).
OK, the message will look like: "Not connected to <uri>, wrong username/password or certificate"

- Peter


On December 2nd, 2013, 8:43 a.m. UTC, Peter Hatina wrote:

Review request for OpenLMI Developers.
By Peter Hatina.

Updated Dec. 2, 2013, 8:43 a.m.

Repository: openlmi-tools

Description

The patch introduces some useful log messages in the connect() function. When connecting to CIMOM, 2 situations may occur:

1. user has provided valid username+password/certificate or is connected via Unix-socket:
   - in that case, output INFO message with "Connected" string
   - by default, lmishell outputs only ERROR messages, so no message will be print out
      - to see the message of successful connection, run lmishell with "-v" or "-m" CLI option

2. user has provided invalid username+password/certificate:
   - output ERROR message with "Not connected" string
   - the log message can be suppressed by running lmishell with "-q" CLI option

Diffs

  • cli/lmi/shell/LMIConnection.py (301fa520d8eacb39676af5e9ff479c3583df864e)
  • cli/lmishell (e493af571c72b9ffc22a500b6716d037faec88c3)

View Diff