This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1740/ |
On May 19th, 2014, 9:39 a.m. UTC, Michal Minar wrote:
src/python/lmi/test/ind.py (Diff revision 1) 144 run() accepts a dictionary describing the actual test case. The dict
145 should contain these keys:
146 147 * 'name' - a short descriptive name to be used to construct
148 handler and subsctiption names; aim is basically to help
149 in case of debugging
Seems like run() doesn't accept anything.On May 19th, 2014, 11:05 a.m. UTC, Alois Mahdal wrote:
TestDriver.run does: def run(self, args): self.args.update(args) result = self._run() self._cleanup() return result IndicationTestDriver._run (or any *TestDriver._run) does not. There's intent to keep the driver interface simple and identical over implementations: Instantiate, call run(case) and, unless you have good reason and you are very careful, throw away.On May 19th, 2014, 11:32 a.m. UTC, Michal Minar wrote:
Ah, you're right. I thought it refers to local _run() method. It's unfortunate naming - having run() and _run() implemented in the same class. Could you please move the comment to the base class instead? Its run() method lacks any docstring. I think it's more appropriate place for this description.
OK, thanks, I'll describe the interface better in the base class. OTOH, the actual semantics of the args parameter need to be defined per implementation, i.e. only IndicationTestDriver will need, and know what to do with args['handlers']. But yes, it is probably little bit confusing; I'll have to think of better way how to describe this.
- Alois
On May 14th, 2014, 4:26 p.m. UTC, Alois Mahdal wrote:
Review request for OpenLMI Developers.
By Alois Mahdal.
Updated May 14, 2014, 4:26 p.m.
Repository:
openlmi-providers
Description
Diffs
|