This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/558/

Ship it!

src/hardware/LMI_PCIDeviceProvider.c (Diff revision 1)
static CMPIStatus LMI_PCIDeviceEnumInstances(
195
        for (i = 0; i < 6; i++) {
Use a constant.

src/hardware/LMI_PCIDeviceProvider.c (Diff revision 1)
static CMPIStatus LMI_PCIDeviceEnumInstances(
208
            for (i = 0; i < 6; i++) {
Use a constant.

Other than that, ship it!

- Jan Synacek


On July 16th, 2013, 2:19 p.m. CEST, Peter Schiffer wrote:

Review request for OpenLMI Developers.
By Peter Schiffer.

Updated July 16, 2013, 2:19 p.m.

Repository: openlmi-providers

Description

Hardware: Update LMI_PCIDevice provider

LMI_PCIDevice provider was updated to match the rest of the providers in the
Hardware, multiple information was added. As main and only source of information
is still libpci library, as udev doesn't provide all necessary information and
if used, it would have to be combined with libpci anyway.

Diffs

  • mof/60_LMI_Hardware.mof (41e80b8d7d314a97205061e5c3c20077b7649cb4)
  • src/hardware/LMI_Hardware.h (227ca51ac006878de22d455e402f404546c053b3)
  • src/hardware/LMI_PCIDeviceProvider.c (e879484a53bc29aa6109ad31a25a9616f03ca3e0)

View Diff