This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/837/ |
On September 6th, 2013, 4:37 p.m. UTC, Roman Rakus wrote:
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 1) KUint32 LMI_JournalMessageLog_ClearLog(213 KUint32_Set(&result, 1);Rather use some constant.
This was made intentionally, the schema explicitly states return values for very method. However the values seem consistent so I turned them into constants.
On September 6th, 2013, 4:37 p.m. UTC, Roman Rakus wrote:
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 1) KUint32 LMI_JournalMessageLog_PositionAtRecord(252 gchar *iter_id;253 sd_journal *journal;init to NULL
This is first initialized by the g_strdup() call, no need for explicit intialization.
On September 6th, 2013, 4:37 p.m. UTC, Roman Rakus wrote:
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 1) KUint32 LMI_JournalMessageLog_PositionAtRecord(269 iter_id = g_strdup(IterationIdentifier->chars);What if strdup fails?
Then journal_iter_parse_iterator_string() as a first user would return FALSE and CMPIStatus* status is set accordingly.
On September 6th, 2013, 4:37 p.m. UTC, Roman Rakus wrote:
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 1) KUint32 LMI_JournalMessageLog_GetRecord(301 gchar *iter_id;302 sd_journal *journal;303 char *data;init to NULL
Same as above, this is not needed.
- Tomáš
On September 6th, 2013, 3:05 p.m. UTC, Tomáš Bžatek wrote:
Review request for OpenLMI Developers.
By Tomáš Bžatek.
Updated Sept. 6, 2013, 3:05 p.m.
Repository:
openlmi-providers
Description
Diffs
|