This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1319/

On December 2nd, 2013, 3:30 p.m. CET, scanbot wrote:

Autoscan finished with errors:
Error: PW.VAR_WITH_UNINITIALIZED_FIELD:
openlmi-providers-0.4.1_75_gf47c906/src/hardware/LMI_DiskDriveProvider.c:65: var_with_uninitialized_field: variable "lmi_hdd" has an uninitialized const field
openlmi-providers-0.4.1_75_gf47c906/src/hardware/LMI_DiskDriveProvider.c:65: caretline:                   ^

Error: PW.VAR_WITH_UNINITIALIZED_FIELD:
openlmi-providers-0.4.1_75_gf47c906/x86_64-redhat-linux-gnu/src/hardware/LMI_DiskDrive.h:5195: var_with_uninitialized_field: variable "self" has an uninitialized const field
openlmi-providers-0.4.1_75_gf47c906/x86_64-redhat-linux-gnu/src/hardware/LMI_DiskDrive.h:5195: primary_file: During compilation of file '/builddir/build/BUILD/openlmi-providers-0.4.1_75_gf47c906/src/hardware/LMI_DiskDriveProvider.c'
openlmi-providers-0.4.1_75_gf47c906/x86_64-redhat-linux-gnu/src/hardware/LMI_DiskDrive.h:5195: caretline:                      ^

Scanned reviews: 1319
Shouldn't be this fixed on konkret side?

- Peter


On December 2nd, 2013, 2:41 p.m. CET, Peter Schiffer wrote:

Review request for OpenLMI Developers.
By Peter Schiffer.

Updated Dec. 2, 2013, 2:41 p.m.

Repository: openlmi-providers

Description

Hardware: Created DiskDrive provider

New provider:
 * LMI_DiskDriveProvider

Also, added missing config init to disk providers.

Diffs

  • mof/60_LMI_Hardware.mof (a50129cdd6007ca2fed9ad48d103079fda4a8905)
  • src/hardware/CMakeLists.txt (2d3512b3e4b7d223ff5fdb3dd94644f26940d8e4)
  • src/hardware/LMI_DiskDriveProvider.c (PRE-CREATION)
  • src/hardware/LMI_DiskPhysicalPackageContainerProvider.c (ef6e41bcdfca59884c5688033dcde81853bc3b26)
  • src/hardware/LMI_DiskPhysicalPackageProvider.c (daa0133e03fc075168979f84bc551b56afa2dd85)
  • src/hardware/LMI_Hardware.h (6ca6ab24b2be7211b3d5e8db4bb72a42fdd64494)
  • src/hardware/smartctl.h (5880e3a992518530c6b878c1f0435c61509e5076)
  • src/hardware/smartctl.c (1067e9ba120e88bc46a023086648e14514c5907f)

View Diff