This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1289/

Autoscan finished with errors:
Error: SIZEOF_MISMATCH (CWE-398):
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:398: suspicious_sizeof: Passing argument "output" of type "char *" and argument "8 /* sizeof (output) */" to function "service_find_all(char *, int)" is suspicious.

Error: CLANG_WARNING:
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414:24: warning: Call to 'malloc' has an allocation size of 0 bytes
#    si->signal_proxy = malloc(si->slist->cnt * sizeof(GDBusProxy *));
#                       ^      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414: returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414: var_assigned: Assigning: "si->signal_proxy" = null return value from "malloc(size_t)".
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:427: dereference: Dereferencing a null pointer "si->signal_proxy".

Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414: returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414: var_assigned: Assigning: "si->signal_proxy" = null return value from "malloc(size_t)".
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:455: dereference: Dereferencing a pointer that might be null "si->signal_proxy" when calling "ind_destroy(ServiceIndication *)".
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:509:9: deref_parm: Directly dereferencing parameter "si->signal_proxy".

Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414: returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414: var_assigned: Assigning: "si->signal_proxy" = null return value from "malloc(size_t)".
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:446: dereference: Dereferencing a pointer that might be null "si->signal_proxy" when calling "ind_destroy(ServiceIndication *)".
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:509:9: deref_parm: Directly dereferencing parameter "si->signal_proxy".

Error: NULL_RETURNS (CWE-476):
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414: returned_null: Function "malloc(size_t)" returns null.
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:414: var_assigned: Assigning: "si->signal_proxy" = null return value from "malloc(size_t)".
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:421: dereference: Dereferencing a pointer that might be null "si->signal_proxy" when calling "ind_destroy(ServiceIndication *)".
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:509:9: deref_parm: Directly dereferencing parameter "si->signal_proxy".

Error: PW.DECLARED_BUT_NOT_REFERENCED:
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.h:81: declared_but_not_referenced: variable "service_allowed_classes" was declared but never referenced
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.h:81: primary_file: During compilation of file '/builddir/build/BUILD/openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/LMI_ServiceProvider.c'
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.h:81: caretline:                    ^

Error: COMPILER_WARNING:
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.c:30: included_from: Included from here.
openlmi-providers-0.4.1_74_g0917b98/src/service-dbus/util/serviceutil.h:81:20: warning: 'service_allowed_classes' defined but not used [-Wunused-variable]
# static const char* service_allowed_classes[] = {
#                    ^

Scanned reviews: 1289

- scanbot


On December 2nd, 2013, 11:34 a.m. UTC, Vitezslav Crhonek wrote:

Review request for OpenLMI Developers.
By Vitezslav Crhonek.

Updated Dec. 2, 2013, 11:34 a.m.

Repository: openlmi-providers

Description

Service: Support indications on instance property modification.

Diffs

  • mof/60_LMI_Service.mof (1a86fec8462402d5f5b5ff4f2661596dca470433)
  • src/service-dbus/CMakeLists.txt (3cc2082ac2b28660b854c5e81a3eb581bac8efb5)
  • src/service-dbus/LMI_ServiceInstanceModificationIndicationProvider.c (PRE-CREATION)
  • src/service-dbus/util/serviceutil.h (fbdadad5be2d37920407783d806d36af476d62cb)
  • src/service-dbus/util/serviceutil.c (50b18b91cd3083a821a6a3be5f682aafc509be3d)

View Diff