This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/875/ |
src/journald/LMI_JournalLogRecordProvider.c (Diff revision 1) | |||
---|---|---|---|
169 | get_string_property(const char *property_name, const CMPIInstance* ci) |
There is a very similar function in the logicalfile provider. Maybe we should move it to the libcommon.
src/journald/LMI_JournalLogRecordProvider.c (Diff revision 1) | |||
---|---|---|---|
175 | if (rc.msg != NULL || (d.state & CMPI_nullValue) == CMPI_nullValue || |
My gut feeling here is that it's better to check for the rc than for the message. if (rc.rc ...) or more explicit and readable ir (rc.rc != CMPI_RC_OK ...)
src/journald/LMI_JournalLogRecordProvider.c (Diff revision 1) | |||
---|---|---|---|
226 | if (r < 0) { |
||
227 | sd_journal_close(journal); |
||
228 | KReturn2(_cb, ERR_FAILED, "Error seeking to the end of the journal: %s\n", strerror(-r)); |
||
229 | } |
These pieces of code are fairly common throughout the code. Wrap in a macro / make a function?
s/fiull/full/ in the description.
- Jan Synacek
On September 18th, 2013, 5:22 p.m. CEST, Tomáš Bžatek wrote:
Review request for OpenLMI Developers.
By Tomáš Bžatek.
Updated Sept. 18, 2013, 5:22 p.m.
Repository:
openlmi-providers
Description
Diffs
|