This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/589/

On July 29th, 2013, 12:37 p.m. CEST, Roman Rakus wrote:

src/setting.c (Diff revision 1)
Setting *setting_new(SettingType setting_type)
75
            setting->typespec.bridge_slave.priority = 32;
76
            setting->typespec.bridge_slave.path_cost = 100;
I don't like these magic numbers.
These are default values taken from NetworkManager, I'll add comment to specify where they come from.

- Radek


On July 23rd, 2013, 2:26 p.m. CEST, Radek Novacek wrote:

Review request for OpenLMI Developers.
By Radek Novacek.

Updated July 23, 2013, 2:26 p.m.

Repository: openlmi-networking

Description

Read brigde slave settings from NM

Diffs

  • src/globals.h (091181c9d61973a9a34b9d04d7d13f368a2f566b)
  • src/setting.h (09f5a258b5c0dd86fe091152f45096dc18bea450)
  • src/setting.c (79548584fa25bc0dc1234c194ea83aafe3caf6b1)
  • src/setting_nm.c (9ea12230fe2645be5a10091548c82aad77362112)
  • src/setting_private.h (c54980d47a9e58cc0ce87ed336beccb3018da2bd)

View Diff