This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/776/

Ship it!

openlmi-mof-register.py (Diff revision 1)
294
           WHERE (mof.fname in ('%(mofs)s') or reg.fname = '%(reg)s')" \
This is vulnerable to SQL injection. Although it's not really a risk in this case.

Looks good to me, ship it.

- Radek Novacek


On August 30th, 2013, 11:08 a.m. CEST, Tomas Smetana wrote:

Review request for OpenLMI Developers.
By Tomas Smetana.

Updated Aug. 30, 2013, 11:08 a.m.

Repository: openlmi-providers

Description

Incorporated some remarks from the previous review. Probably still needs some touches. Comments welcome.

Diffs

  • openlmi-mof-register.py (PRE-CREATION)

View Diff