This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1225/ |
src/account/test/TestAccountLmishell.py (Diff revision 1) | |||
---|---|---|---|
60 | myuser = "lmishell-user" + id_generator(18) |
possibly add more "exotic" utf8 characters to validate readiness
src/account/test/TestAccountLmishell.py (Diff revision 1) | |||
---|---|---|---|
147 | badchar = [chr(i) for i in xrange(1, 128) if chr(i) not in set(string.ascii_letters + string.digits + '$_')] |
this expects ascii unlike system behaviour is likely to depend on locale settings. should not the test adjust locale, restart services and pick character subset accordingly? or just stick with the locale or at least add precondition check for locale setting?
- Ales Ledvinka
On November 8th, 2013, 1:34 p.m. UTC, Petr Sklenar wrote:
Review request for OpenLMI Developers.
By Petr Sklenar.
Updated Nov. 8, 2013, 1:34 p.m.
Repository:
openlmi-providers
Description
Diffs
|