Due to changes in lmishell (v0.8 -> v0.9) some usage patterns won't work.
I've picked few of them and opened an issue. Please try the test against
the software provider with update openlmi-tools to ensure validity of this code.
This won't work, use:
iname.InstalledSoftware.InstanceID
Please use:
it.InstanceID
src/software/test/testSoftware.py
(Diff revision 1)
|
|
|
247 |
path = iname.path["InstalledSoftware"]["InstanceID"] |
|
|
248 |
name = path[len("LMI:LMI_SoftwareIdentity:"):] |
|
|
249 |
package_list.append(name) |
nevra = iname.InstalledSoftware.InstanceID[len("LMI:LMI_SoftwareIdentity:"):]
package_list.append(nevra)
name = it.InstanceID[len("LMI:LMI_SoftwareIdentity:"):]
- Michal Minar
On October 30th, 2013, 2:03 p.m. UTC, Jan Grec wrote:
Review request for OpenLMI Developers.
By Jan Grec.
Updated Oct. 30, 2013, 2:03 p.m.
Repository:
openlmi-providers
Description
software - tests: software test suite with basic tests
This is only a "current-status" review. I'll be very thankful for any comments on what's wrong, how the structure should look like, etc.
My TODO is to
* repair all broken tests
* add all tests mentioned
* bind test suite with new LmiTestCase class
I apologize for inconvenience, but I wasn't able to save previous review notes.
|
Diffs
- src/software/test/lmi-test.repo (PRE-CREATION)
- src/software/test/testSoftware.py (PRE-CREATION)
View Diff
|