This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1147/

On October 30th, 2013, 3:44 p.m. CET, Radek Novacek wrote:

src/software/test/testSoftware.py (Diff revision 1)
284
The matching against 'yum list available' is missing. If it is on purpose, add at least a TODO comment.

On October 30th, 2013, 4:29 p.m. CET, Michal Minar wrote:

This should be achievable. Try to remove installed packages and duplicities from lmi list and compare them. (I haven't tried).
Skipping this one for now.

Although it'd be great to know exactly whether listing available packages returns correct available packages, there's no exact process to get them in lmi itself.
>From packages returned, we'd have to remove all packages with package names that are already installed and their epoch or version is lesser omitting updates which requires package name parsing etc. etc.
I suppose this is going to be an openlmi-scripts functionality and therefore should be tested there, not in lmi itself.

- Jan


On October 30th, 2013, 3:03 p.m. CET, Jan Grec wrote:

Review request for OpenLMI Developers.
By Jan Grec.

Updated Oct. 30, 2013, 3:03 p.m.

Repository: openlmi-providers

Description

software - tests: software test suite with basic tests

This is only a "current-status" review. I'll be very thankful for any comments on what's wrong, how the structure should look like, etc.

My TODO is to
  * repair all broken tests
  * add all tests mentioned
  * bind test suite with new LmiTestCase class

I apologize for inconvenience, but I wasn't able to save previous review notes.

Diffs

  • src/software/test/lmi-test.repo (PRE-CREATION)
  • src/software/test/testSoftware.py (PRE-CREATION)

View Diff