This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1165/

Ship it!

src/lmi/storage/LMI_MountPoint.py (Diff revision 1)
def __init__ (self, *args, **kwargs):
54
            directory['CSName'] != self.config.system_name):
55
            directory['CSName'] != get_system_name()):
Same indent used for branched code block below. Please consider indentation adjustment.

- Michal Minar


On October 31st, 2013, 2:22 p.m. UTC, Jan Safranek wrote:

Review request for OpenLMI Developers.
By Jan Safranek.

Updated Oct. 31, 2013, 2:22 p.m.

Repository: openlmi-storage

Description

Use get_system_name() to get name from CIMOM instead of simple domain name

ComputerSystem.Name is now opaque to the provider and the CIMOM can use any
CoputerSystem implementation.

Diffs

  • src/lmi/storage/CapabilitiesProvider.py (edd7b888526d6894957d2c01f9894ce5a25acfdd)
  • src/lmi/storage/ExtentProvider.py (dcff358eaab7ed7075ad358bf1253d4fc31e33d3)
  • src/lmi/storage/FormatProvider.py (a3323b722ac01f7bc3eb7ae9e9981ff2f8c808b8)
  • src/lmi/storage/LMI_AttachedFileSystem.py (86185e681dc7fd85cca9c48707f02495e783b418)
  • src/lmi/storage/LMI_BlockStorageStatisticalData.py (ab586d2d13caf0ca2fa91e175b1c16dd4854bbb5)
  • src/lmi/storage/LMI_HostedFileSystem.py (e0487d7ab744289c2874a4ba601abc08bd68d90e)
  • src/lmi/storage/LMI_HostedMount.py (0e4803d5d3b1ba0dd1fecc8730c6d5e787489613)
  • src/lmi/storage/LMI_HostedStorageService.py (c1778e5e74a547c36680a01065d7a95a7507e70b)
  • src/lmi/storage/LMI_MountPoint.py (470028e358b713b96eeaff6a9fd91689314776f0)
  • src/lmi/storage/LMI_SystemStorageDevice.py (b9f5ba030100c25a515153cdbb8f4899ba1054db)
  • src/lmi/storage/ServiceProvider.py (31af03e6db2004a4d5a856faf9d9bfe2186b3905)
  • src/lmi/storage/cimom_entry.py (6a3c35ae661f39c603dbbc8ed21ac0fe09d13187)

View Diff