This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/470/

On June 27th, 2013, 9:16 a.m. UTC, Radek Novacek wrote:

src/account/CMakeLists.txt (Diff revision 1)
40
include_directories(${CMAKE_CURRENT_BINARY_DIR} ${CMPI_INCLUDE_DIR} ${LIBUSER_INCLUDE_DIRS})
42
include_directories(${CMAKE_CURRENT_BINARY_DIR} ${CMPI_INCLUDE_DIR} ${LIBUSER_INCLUDE_DIRS})
41
43
42
target_link_libraries(${LIBRARY_NAME} openlmicommon ${KONKRETCMPI_LIBRARIES} ${LIBUSER_LIBRARIES})
44
target_link_libraries(${LIBRARY_NAME} openlmicommon ${KONKRETCMPI_LIBRARIES} ${LIBUSER_LIBRARIES})
43
45
46
47
include_directories(${CMAKE_CURRENT_BINARY_DIR} ${CMPI_INCLUDE_DIR} ${IM_INCLUDE_DIRS})
48
49
target_link_libraries(${LIBRARY_NAME} openlmicommon ${KONKRETCMPI_LIBRARIES} ${IM_LIBRARIES})
50
This looks like that include_directories and target_link_libraries are here twice. Why?
In fact they are trice. I didn't know they can be in one.

- Roman


On June 26th, 2013, 2:42 p.m. UTC, Roman Rakus wrote:

Review request for OpenLMI Developers.
By Roman Rakus.

Updated June 26, 2013, 2:42 p.m.

Repository: openlmi-providers

Description

Account: Indications for creation and deletion

Signed-off-by: Roman Rakus <rrakus@redhat.com>

Diffs

  • mof/60_LMI_Account.mof (d79db352f5d9b9891530a182f108720dc703e18a)
  • src/account/CMakeLists.txt (38ecd021a011c76a6f964d7b344a092787541b85)
  • src/account/LMI_AccountInstanceCreationIndicationProvider.c (PRE-CREATION)
  • src/account/LMI_AccountInstanceDeletionIndicationProvider.c (PRE-CREATION)
  • src/account/indication_common.h (PRE-CREATION)
  • src/account/indication_common.c (PRE-CREATION)

View Diff