This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1315/

Ship it!

I would use 'Error connecting to %s: %s', but that's just a minor nit. Feel free to push it as it is.

- Jan Safranek


On December 2nd, 2013, 10:48 a.m. CET, Peter Hatina wrote:

Review request for OpenLMI Developers.
By Peter Hatina.

Updated Dec. 2, 2013, 10:48 a.m.

Repository: openlmi-tools

Description

The patch introduces some useful log messages in the connect() function. When connecting to CIMOM, 2 situations may occur:

1. user has provided valid username+password/certificate or is connected via Unix-socket:
   - in that case, output INFO message with "Connected" string
   - by default, lmishell outputs only ERROR messages, so no message will be print out
      - to see the message of successful connection, run lmishell with "-v" or "-m" CLI option

2. user has provided invalid username+password/certificate:
   - output ERROR message with "Not connected" string
   - the log message can be suppressed by running lmishell with "-q" CLI option

Diffs

  • cli/lmi/shell/LMIConnection.py (52c99228ac7c37ddea77fa4fad6a57813daa4b9e)
  • cli/lmishell (e493af571c72b9ffc22a500b6716d037faec88c3)

View Diff