This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/837/ |
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 2) | |||
---|---|---|---|
33 | #define CIM_MESSAGELOG_ITERATOR_RESULT_SUCCESS 0 |
This should map to the konkret's "OK" code rather then to exact number. If you disagree then see the PositionAtRecord method comment regarding returning of result.
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 2) | |||
---|---|---|---|
49 | #if 0 |
remove or is this future work?
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 2) | |||
---|---|---|---|
KUint32 LMI_JournalMessageLog_PositionAtRecord( |
|||
236 | KSetStatus(status, ERR_NOT_SUPPORTED); |
260 | if (IterationIdentifier->null || ! IterationIdentifier->exists || |
duverujem cimmomu/konkretu za kazdych okolnosti nebo radsi pridat: NULL == IterationIdentifier || ... NULL == MoveAbsolute NULL == RecordNumber ...
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 2) | |||
---|---|---|---|
KUint32 LMI_JournalMessageLog_PositionAtRecord( |
|||
264 | KUint32_Set(&result, CIM_MESSAGELOG_ITERATOR_RESULT_FAILED); |
This is useless since the status is not konkret's ok. See instead of filenameProvider.c see the filename.h the _Dispatch_Method() for more details on result processing of invoked method.
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 2) | |||
---|---|---|---|
KUint32 LMI_JournalMessageLog_PositionAtRecord( |
|||
270 | KUint32_Set(&result, CIM_MESSAGELOG_ITERATOR_RESULT_FAILED); |
same as 264
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 2) | |||
---|---|---|---|
KUint32 LMI_JournalMessageLog_PositionAtRecord( |
|||
277 | KUint32_Set(&result, CIM_MESSAGELOG_ITERATOR_RESULT_FAILED); |
missing status or status from previous operation. depending on the operation status if it's other then KOkay(status) match the line returning result might be useless depending on the status code returned
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 2) | |||
---|---|---|---|
KUint32 LMI_JournalMessageLog_PositionAtRecord( |
|||
283 | KUint32_Set(&result, CIM_MESSAGELOG_ITERATOR_RESULT_FAILED); |
same as 277
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 2) | |||
---|---|---|---|
KUint32 LMI_JournalMessageLog_GetRecord( |
|||
314 | KUint32_Set(&result, CIM_MESSAGELOG_ITERATOR_RESULT_FAILED); |
same as 264
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 2) | |||
---|---|---|---|
KUint32 LMI_JournalMessageLog_GetRecord( |
|||
321 | KUint32_Set(&result, CIM_MESSAGELOG_ITERATOR_RESULT_FAILED); |
same as 277
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 2) | |||
---|---|---|---|
KUint32 LMI_JournalMessageLog_GetRecord( |
|||
328 | KUint32_Set(&result, CIM_MESSAGELOG_ITERATOR_RESULT_FAILED); |
same as 277
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 2) | |||
---|---|---|---|
KUint32 LMI_JournalMessageLog_DeleteRecord( |
|||
362 | KUint32_Set(&result, CIM_MESSAGELOG_ITERATOR_RESULT_NOT_SUPPORTED); |
same as 264
src/journald/LMI_JournalMessageLogProvider.c (Diff revision 2) | |||
---|---|---|---|
KUint32 LMI_JournalMessageLog_WriteRecord( |
|||
380 | KUint32_Set(&result, CIM_MESSAGELOG_ITERATOR_RESULT_NOT_SUPPORTED); |
same as 264
- Ales Ledvinka
On September 20th, 2013, 10:05 a.m. UTC, Tomáš Bžatek wrote:
Review request for OpenLMI Developers.
By Tomáš Bžatek.
Updated Sept. 20, 2013, 10:05 a.m.
Repository:
openlmi-providers
Description
Diffs
|