This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/854/

src/account/test/testAccount.py (Diff revision 7)
def test_modify_user(self):
def test_create_modify_user_in_loop_bz1001490(self):
88
            user = lams1.CreateAccount(Name=myuser, System=cs1)
88
            user = lams1.CreateAccount(Name=myuser, System=cs1)
89
            user = self.conn.root.cimv2.LMI_Account.first_instance(key="Name", value=myuser)
89
            user = self.conn.root.cimv2.LMI_Account.first_instance(key="Name", value=myuser)
Double initialization of user AGAIN!

src/account/test/testAccount.py (Diff revision 7)
116
        user = self.lams.CreateAccount(Name=self.myuser, System=self.cs)
117
        user = self.conn.root.cimv2.LMI_Account.first_instance(key="Name", value=self.myuser)
Why us user initialized two times?

src/account/test/testAccount.py (Diff revision 7)
128
        self.assertEqual(field_in_passwd(user.name,5),myhome)
Where is cleanup?
I know about tearDown method but i what i miss is some: self.user =

Maybe self.user should be self.users and should be list of users which you want to delete.

- Robin Hack


On September 13th, 2013, 12:41 p.m. UTC, Robin Hack wrote:

Review request for OpenLMI Developers.
By Robin Hack.

Updated Sept. 13, 2013, 12:41 p.m.

Repository: openlmi-providers

Description

Account: Added QA test for account provider.

Diffs

  • src/account/test/testAccount.py (PRE-CREATION)

View Diff