This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/691/ |
On August 8th, 2013, 6:06 a.m. UTC, Michal Minar wrote:
cli/lmi/shell/LMIConnection.py (Diff revision 2) def __init__(self, hostname, username="", password="", interactive=False, use_cache=True, \142 def __repr__(self):shouldn't this be a __str__() ? __repr__ should return representation, which could be used in python expression to reconstruct the object. If not possible, it should return some description enclosed with '<' and '>'.
Nope. Python doc: Called by the repr() built-in function and by string conversions (reverse quotes) to compute the “official” string representation of an object.
On August 8th, 2013, 6:06 a.m. UTC, Michal Minar wrote:
cli/lmi/shell/LMIInstance.py (Diff revision 2) def references(self, **kwargs):471 return map(lambda ref: lmi_wrap_cim_instance(self._client, ref, ref.classname, \470 return map(lambda ref: lmi_wrap_cim_instance(self._conn, ref, ref.classname, \in python 2, generator expression is more effective than map(): [lmi_write_cim_instance(...) for ... ]
OK.
- Peter
On August 8th, 2013, 5:30 a.m. UTC, Peter Hatina wrote:
Review request for OpenLMI Developers.
By Peter Hatina.
Updated Aug. 8, 2013, 5:30 a.m.
Repository:
openlmi-tools
Description
Diffs
|