This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1740/

And one more issue: please split additions to lmi.test and account/tests into two individual commits.

src/python/lmi/test/ind.py (Diff revision 1)
31
class IndicationStreamTestCase(unittest.TestCase):
Please, add some docstring.

Add some comments on attributes/methods that need to be overriden by subclasses (options, default_args).

I would turn *options* property into a virtual method (get_driver_options()) and provide some sane defaults in default implementation. The same for default_args.

- Michal Minar


On May 14th, 2014, 4:26 p.m. UTC, Alois Mahdal wrote:

Review request for OpenLMI Developers.
By Alois Mahdal.

Updated May 14, 2014, 4:26 p.m.

Repository: openlmi-providers

Description

Add indication testing framework

Set of classes and methods to help with event stream oritnted
tests.

Diffs

  • src/account/test/common.py (95abd381089506c3f9b4d6632f2303da322fa585)
  • src/python/lmi/test/ind.py (PRE-CREATION)
  • src/python/lmi/test/util.py (699507c2340e9a50ff22ce08b67fe3e0a3f9eef8)

View Diff