This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/440/

On June 10th, 2013, 2:05 p.m. UTC, Roman Rakus wrote:

Look good.
In future it would be good to check also for invalid queries.

On June 11th, 2013, 11:04 a.m. UTC, Radek Novacek wrote:

Yes, checking the queries should be added, but I'll have to think about how to do it correctly.
The logic for checking queries should be in the provider - when the query (or filter) is not valid, the provider will return not OK result. The test could test if provider do it like this. So it will be test to check if provider is correctly checking.

- Roman


On June 11th, 2013, 11:05 a.m. UTC, Radek Novacek wrote:

Review request for OpenLMI Developers.
By Radek Novacek.

Updated June 11, 2013, 11:05 a.m.

Repository: openlmi-networking

Description

test: test for lifetime indications

This commit also adds indication infrastructure to the test_base in
order to simplify its usage.

Diffs

  • test/test_base.py (af75041038d3dc185772959e678a409518ca4423)
  • test/test_indications.py (PRE-CREATION)

View Diff