This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/701/

On August 9th, 2013, 8:03 a.m. UTC, Radek Novacek wrote:

cli/lmi/shell/LMIUtil.py (Diff revision 2)
136
    cast_func = cast[t] if t.lower() in cast else lambda x: x
Shouldn't it be like:
... cast[t.lower()] if t.lower() in cast ...

This way it checks if lowercased t is key in the dict but it gets non-lowercased key.
Yes, I will fix that.

- Peter


On August 9th, 2013, 7:53 a.m. UTC, Peter Hatina wrote:

Review request for OpenLMI Developers.
By Peter Hatina.

Updated Aug. 9, 2013, 7:53 a.m.

Repository: openlmi-tools

Description

When retrieving constant values from either LMIClass or LMIMethod, cast them to python/lmishell native types before returning.

Diffs

  • cli/lmi/shell/LMIConstantValues.py (6e564ac413f3fbcb0afc3a8406b55d7701a3ab71)
  • cli/lmi/shell/LMIUtil.py (5954b9650f358e53fb75e08d9aac30365be8964f)

View Diff