This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/1667/

On May 6th, 2014, 11:21 a.m. CEST, Michal Minar wrote:

src/software-dbus/sw-utils.c (Diff revision 1)
done:
419
    while (values_p[++values_p_count]);
Usually caller does know how many values are there, therefor I'd add also 
"int values_n" parameter. If negative (caller does not know), this line would be used as a fallback to compute it.
Yes, but for example, PackageKit library uses similar approach - NULL terminated arrays. So, I just stayed with it..

On May 6th, 2014, 11:21 a.m. CEST, Michal Minar wrote:

src/software-dbus/sw-utils.c (Diff revision 1)
726
        g_object_get(g_ptr_array_index(repos, i), "repo_id", &repo_id, NULL);
Free repo_id.

Even better, use pk_repo_detail_get_id () - no free needed.
pk_repo_detail_get_id() is available only since PackageKit 0.9.1. F20 has 0.8.17.

On May 6th, 2014, 11:21 a.m. CEST, Michal Minar wrote:

src/software-dbus/sw-utils.c (Diff revision 1)
829
    g_object_get(al, "repo-id", &repo_id_a, NULL);
830
    g_object_get(bl, "repo-id", &repo_id_b, NULL);
Use pk_repo_detail_get_id ()
I can't - pk_repo_detail_get_id() is available only since PackageKit 0.9.1. F20 has 0.8.17.

- Peter


On May 5th, 2014, 5:27 p.m. CEST, Peter Schiffer wrote:

Review request for OpenLMI Developers.
By Peter Schiffer.

Updated May 5, 2014, 5:27 p.m.

Repository: openlmi-providers

Description

Software-dbus: implemented LMI_ResourceForSoftwareIdentityProvider

Diffs

  • src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c (9332f62e392103e39a700cedcfaadf72df8e5f53)
  • src/software-dbus/LMI_SoftwareIdentityProvider.c (7e03badf0113ebc981a24d20ccac60131dfb8d74)
  • src/software-dbus/LMI_SoftwareIdentityResourceProvider.c (fec2794131a6194510364e45969995729e80108c)
  • src/software-dbus/sw-utils.h (16e6ca11e4714ab337c7e554f7c8ced5b06bd37b)
  • src/software-dbus/sw-utils.c (76ca58bd0129c3d12695d22da77fb3613c8685b1)

View Diff