Review Request 1938: Implemented LMI_ScsiScan method.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1938/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Implemented LMI_ScsiScan method.
LMI_ScsiScan is just a copy of DMTF's ScsiScan, only with proper return value
'4096' when a job is returned - DMTF's method does not have such return value.
Also, I removed its parameters we do not support for now, it may be added
in future versions.
Diffs
-----
mof/LMI_Storage-BlockStorage.mof 22e2e2018d0294d11b76017cd00fbd34ac32619d
mof/LMI_Storage-MethodParameters.mof ac0271ed3e96c40a29502da00dc8433be465a286
openlmi-storage.spec a9226e01cfe6530cf40f9efe0629703c01a4144f
src/lmi/storage/LMI_StorageConfigurationService.py 431ee211b9fb5c99858c897049e6ddfd8b962298
Diff: http://reviewboard-openlmi.rhcloud.com/r/1938/diff/
Testing
-------
Thanks,
Jan Safranek
9 years, 7 months
Review Request 1896: tools - shell: better handle job output parameters
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1896/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
shell: better handle job output parameters
Due to openlmi's workaround of pegasus' shortcoming, JobOutParameters
property of job instance is something else then it should be. It's an
instance of __MethodParameters_<method_name>_Result class which derives
from __MethodParameters_<method_name> class. The latter contains input
parameters of asynchronous method. Therefor JobOutParameters may contain
input parameters as well. Let's filter them out because this may confuse
client scripts.
Diffs
-----
cli/lmi/shell/LMIMethod.py 97b8cb66066ec968c0b05e72de0e7074482abdcb
Diff: http://reviewboard-openlmi.rhcloud.com/r/1896/diff/
Testing
-------
Thanks,
Michal Minar
9 years, 8 months
Review Request 1935: software-dbus [3/3] software-dbus: optimalized FindIdentity() function
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1935/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software-dbus: optimalized FindIdentity() function
Added utility function `get_repo_dets_for_pk_pkgs()` associating
PkPackages with PkRepoDetails that provides them. With this function
enumeration of LMI_ResourceForSoftwareIdentity could be simplified and
FindIdentity() method speeded up.
Old FindIdentity() was very slow when listing packages of particular
repository without any additional filter. Provider queried PackageKit
once for each installed package to test whether it is provided by
particular repository or not. This patch limits number of queries to
minimum. Many packages can be resolved in one query.
Diffs
-----
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c 731c5c902e033cc3ec91acf652e739d1b6c26c85
src/software-dbus/LMI_SoftwareInstallationServiceProvider.c b629f5f92d3611c97425144bed444886cb1c3482
src/software-dbus/sw-utils.h 8ce90ba240097c05db8f9b083aae01147ab21c5f
src/software-dbus/sw-utils.c 211f669539e1086fa8235d7dac3d6f3df26b4034
Diff: http://reviewboard-openlmi.rhcloud.com/r/1935/diff/
Testing
-------
Thanks,
Michal Minar
9 years, 8 months
Review Request 1934: software-dbus [2/3] software-dbus: enhanced repository listing functions
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1934/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software-dbus: enhanced repository listing functions
Allow to filter repositories by their state (enabled/disabled).
Diffs
-----
src/software-dbus/LMI_HostedSoftwareIdentityResourceProvider.c ed0a44f8c24ba26211fbf4aa0d420852967bb011
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c 731c5c902e033cc3ec91acf652e739d1b6c26c85
src/software-dbus/LMI_SoftwareIdentityResourceProvider.c 607660e80ba3b27a2d28be61a8aee8ebea6cbea6
src/software-dbus/sw-utils.h 8ce90ba240097c05db8f9b083aae01147ab21c5f
src/software-dbus/sw-utils.c 211f669539e1086fa8235d7dac3d6f3df26b4034
Diff: http://reviewboard-openlmi.rhcloud.com/r/1934/diff/
Testing
-------
Thanks,
Michal Minar
9 years, 8 months
Review Request 1933: software-dbus [1/3] software-dbus: rename cleanup function of SwPackage
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1933/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
software-dbus: rename cleanup function of SwPackage
Fuctions prefixed with `free_` with single pointer argument are used to
release all resources referenced by data structure and to release the
data itself. SwPackage is usually statically allocated and therefor
it needs only to be cleared, not freed entirely. `clean_sw_package()`
buetter describes what the function does.
Diffs
-----
src/software-dbus/LMI_AffectedSoftwareJobElementProvider.c eb03358db0a870addb7bd1b8a436e970b605a8f2
src/software-dbus/LMI_InstalledSoftwareIdentityProvider.c 0658367cb72e346b23cd016d10f35cb9a3066249
src/software-dbus/LMI_MemberOfSoftwareCollectionProvider.c 84cea07bf1d65c8ff2c9cc98bf9f236a899be9eb
src/software-dbus/LMI_ResourceForSoftwareIdentityProvider.c 731c5c902e033cc3ec91acf652e739d1b6c26c85
src/software-dbus/LMI_SoftwareIdentityCheckUnixFileProvider.c 2af014a65da766a78a23ce5ec3693893de4eaff2
src/software-dbus/LMI_SoftwareIdentityChecksProvider.c a00a67f8948a5b56c6a3338ce74b1845dc69612c
src/software-dbus/LMI_SoftwareIdentityProvider.c db07d63cc0d72001a73f7d73d412590d3c7fa369
src/software-dbus/LMI_SoftwareInstallationServiceProvider.c b629f5f92d3611c97425144bed444886cb1c3482
src/software-dbus/lmi_sw_job.c 7bcbb8d917286bf21815843a7b5dc806a16d5149
src/software-dbus/sw-utils.h 8ce90ba240097c05db8f9b083aae01147ab21c5f
src/software-dbus/sw-utils.c 211f669539e1086fa8235d7dac3d6f3df26b4034
Diff: http://reviewboard-openlmi.rhcloud.com/r/1933/diff/
Testing
-------
Thanks,
Michal Minar
9 years, 8 months
Review Request 1932: jobmgr: don't truncate GType's value
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1932/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
jobmgr: don't truncate GType's value
GType is a long integer that can not be treated as an unsigned int. Full
pointer length needs to be utilized when used as key of binary tree to
avoid colisions.
Diffs
-----
src/libs/jobmanager/job_manager.c a5a0e8d1ed3a9a05ae4c9a3d2606a87fa4fcc28d
src/libs/libopenlmi/openlmi-utils.h d3245e7ee8e51144c5c939c816bb1a4cfb76b774
src/libs/libopenlmi/openlmi-utils.c 20348b23a305d4c237cfc1322ae4ed9e5e9195c1
Diff: http://reviewboard-openlmi.rhcloud.com/r/1932/diff/
Testing
-------
Thanks,
Michal Minar
9 years, 8 months
Review Request 1940: lmishell, introduce LMIInstanceName.delete()
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1940/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
Allow LMIInstanceName to call DeleteInstance, as well.
Diffs
-----
cli/lmi/shell/LMIInstanceName.py 2e45a8b8b21cb0f2a6c1ede7274384e22ba87e65
doc/src/shell/instance_names.rst 3644b0bd233c0253b0000003221facc29ec42d69
Diff: http://reviewboard-openlmi.rhcloud.com/r/1940/diff/
Testing
-------
Let's assume, that there is a "deleteme" account present on a managed system. Then, we can execute following:
```python
> c = connect(...)
> iname = c.root.cimv2.LMI_Account.first_instance_name({"Name": "deleteme"})
> iname.delete()
True
> iname.is_deleted
True
>
```
Thanks,
Peter Hatina
9 years, 8 months