Review Request 1470: tools [2/4] terminate with exit code of last command executed
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1470/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
terminate with exit code of last command executed
Make sure that return code of triggered command gets propagated to the
application's entry point.
In interactive mode, meta-command shall exit with the return code of the
last command executed. Note that exit is also a command (returning 0 by
default).
Resolves ticket #174
Original commit digest in openlmi-scripts repo:
0580e779fee8bcd21dd00b2374c96902c1b49cf1
Diffs
-----
cli/lmi/scripts/_metacommand/__init__.py e26c1b7be981ccc34efdccd97cf2dfabe319974f
cli/lmi/scripts/common/command/base.py dcf40bf2339b3f1dd5396705c6543b9eb687cb24
cli/lmi/scripts/common/command/session.py 1be7fecae5b54cb853fc95560cbe607c0e80fd86
Diff: http://reviewboard-openlmi.rhcloud.com/r/1470/diff/
Testing
-------
Thanks,
Michal Minar
10 years, 2 months
Review Request 1503: Place temporary files into /run/openlmi-storage by default.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/1503/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-storage
Description
-------
Place temporary files into /run/openlmi-storage by default.
/tmp is not safe for temporary files, any rogue process can remove or modify
them. Let's put the provider temporary files to /run/openlmi-storage in
our sample storage.conf, hoping that distros implement appropriate SELinux
(or similar) policy.
This patch includes also necessary scaffolding for systemd to create the
directory on boot.
Diffs
-----
MANIFEST.in 38d6cfebbee379e30555b99aace37c3e9a7f87c3
openlmi-storage.spec d5014d2c6466d316ac08528af73473cee61baaca
openlmi-storage.tmpfiles.conf PRE-CREATION
storage.conf 5993fc85f903edf844bfddf66ec783d568b0e2eb
Diff: http://reviewboard-openlmi.rhcloud.com/r/1503/diff/
Testing
-------
Thanks,
Jan Safranek
10 years, 2 months