Review Request 426: Account [1/1] Account: Use asprintf instead of snprintf
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/426/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Account: Use asprintf instead of snprintf
Signed-off-by: Roman Rakus <rrakus(a)redhat.com>
Diffs
-----
src/account/LMI_AccountManagementServiceProvider.c 1af6cf4f55f574d3bf665202ff7b55224a8d9009
src/account/LMI_AccountProvider.c 27be7e15f706b681cf07f83cec56fef2ccc7ecf5
src/account/LMI_AssignedAccountIdentityProvider.c 323a582217cd1c101863cc489b3e4ee94aa3a4ff
src/account/LMI_AssignedGroupIdentityProvider.c a9037f1bd86a39ef21869796a692a0ec85affb08
src/account/LMI_GroupProvider.c a9c547724ecf8e66f92efb1677ee3b6f348f6051
src/account/LMI_IdentityProvider.c 92c2b0119a3dd81ca62be99c6e09f894f46841cd
src/account/LMI_MemberOfGroupProvider.c dddd2e80952d7a1bedc0a0291ada56b5d7a1aea9
src/account/LMI_ServiceAffectsIdentityProvider.c 64e218b4068c696dbb5479d7e73c2f38b4fc0cb5
Diff: http://reviewboard-openlmi.rhcloud.com/r/426/diff/
Testing
-------
Thanks,
Roman Rakus
10 years, 10 months
Review Request 439: openlmi-networking <indications> [4/5] Add Lifetime indication
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/439/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
Add Lifetime indication
Lifetime indication for classes IPNetworkConnection and
IPAssignmentSettingData.
Diffs
-----
mof/LMI_Networking.mof 30e7312c2c764e059c335d525d51c80df2b72943
src/CMakeLists.txt 793d9547dcdb575070529296178ba9f81f3fc2ac
src/LMI_NetworkInstCreationProvider.c PRE-CREATION
src/LMI_NetworkInstDeletionProvider.c PRE-CREATION
src/LMI_NetworkInstModificationProvider.c PRE-CREATION
src/connection_nm.c b664ca2c13091f567d6228b5ce3c595758edecec
src/indications.h PRE-CREATION
src/indications.c PRE-CREATION
src/network.h 27577dd4d8fd7be278decd5e6ae251063935f08f
src/network.c 607bd834709a86c8bfe51ac9122d0842b23b1cd9
src/network_nm.c 6d2eacf805dba3dd64e20f3eeae0b69bd49c170a
src/network_private.h a5c08c3350514816dc859fc9ead09ad422e5bac6
src/port_nm.c 5da6eba639823d133f07e5170b72b4337a679069
Diff: http://reviewboard-openlmi.rhcloud.com/r/439/diff/
Testing
-------
Thanks,
Radek Novacek
10 years, 10 months
Review Request 438: openlmi-networking <indications> [3/5] Move EnumInstances of port-based classes to common function
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/438/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
Move EnumInstances of port-based classes to common function
Move EnumerateInstances of IPNetworkConnection, LANEndpoint and
EthernetPort to one common function in order to deduplicate code that is
almost the same.
Also the creation of instances of above mentioned classes is moved to
separate function. This will be needed for indication support.
Diffs
-----
src/CMakeLists.txt 793d9547dcdb575070529296178ba9f81f3fc2ac
src/LMI_EthernetPortProvider.c f02cb70df835cb70f4454fa86e2ff2d218673457
src/LMI_IPNetworkConnectionProvider.c 8eace4b6db6c4441c6f480c7d446c4c2b58abf78
src/LMI_LANEndpointProvider.c ea35f7ca2cc6185ae72d6bfdb5f22458922c28ce
src/ipnetworkconnection.h PRE-CREATION
src/ipnetworkconnection.c PRE-CREATION
Diff: http://reviewboard-openlmi.rhcloud.com/r/438/diff/
Testing
-------
Thanks,
Radek Novacek
10 years, 10 months
Review Request 437: openlmi-networking <indications> [2/5] IPAssignmentSettingDataEnumInstances cleanup
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/437/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
IPAssignmentSettingDataEnumInstances cleanup
* Move conversion from internal data structures to CIM into separate
functions and make them public
* Use enum instead of classname for getting instances of given class
Diffs
-----
src/LMI_DHCPSettingDataProvider.c 597240126af4906f0d72b2b18dd04c04d4d1a1db
src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c c2563e421cd02493358d075529e70365fcbcdeeb
src/LMI_IPAssignmentSettingDataProvider.c 21567e6246c97bc17cf080024c7eca24442643bb
src/LMI_IPRouteSettingDataProvider.c 9122084e717c41718468cb13e8ca3824345ffbea
src/ipassignmentsettingdata.h 30a280803264fffc3f754d832544a8fc2a23d763
src/ipassignmentsettingdata.c dd6208228b700f3663569f81e88eb07cee39fba7
Diff: http://reviewboard-openlmi.rhcloud.com/r/437/diff/
Testing
-------
Thanks,
Radek Novacek
10 years, 10 months
Review Request 436: openlmi-networking <indications> [1/5] Fix threading
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/436/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
Fix threading
Background thread need to have CMPI context assigned and CMPI broker
needs to be aware of the thread in order to use CMPI function from the
thread. This is required for indications to work.
Diffs
-----
src/LMI_BindsToLANEndpointProvider.c dee5197300e7080cf77eb77555ceeb13a6322f23
src/LMI_DHCPSettingDataProvider.c 597240126af4906f0d72b2b18dd04c04d4d1a1db
src/LMI_DNSProtocolEndpointProvider.c 85f6a63796fb730ef8a99ead031e82c3de673983
src/LMI_DNSSettingDataProvider.c 991fdcbf3e924ed1ad9912880bf3d2ef9ee3f0a8
src/LMI_EndpointForIPNetworkConnectionProvider.c 071d3da00fadf6f8c5f43e7841d2fc912111655d
src/LMI_EndpointIdentityProvider.c dd2b464480fce4353454d9891d8a94fac8fc61a1
src/LMI_EthernetPortProvider.c f02cb70df835cb70f4454fa86e2ff2d218673457
src/LMI_EthernetPortStatisticsProvider.c 9413e635986c9376d0869ebc787fa432c0cb9f40
src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c c2563e421cd02493358d075529e70365fcbcdeeb
src/LMI_HostedIPConfigurationServiceProvider.c 668b270c39f64bf414f5090d95323d10b465b8c1
src/LMI_IPAssignmentSettingDataProvider.c 21567e6246c97bc17cf080024c7eca24442643bb
src/LMI_IPConfigurationServiceAffectsElementProvider.c 3313422e138d60da3f3dd754110115917a14c3ea
src/LMI_IPConfigurationServiceProvider.c baba1e78d148429d788cc7d7516e788e3cb11c9c
src/LMI_IPElementSettingDataProvider.c f68dbc33ce366a2a8ca49c2a2de50eeb1185c34b
src/LMI_IPNetworkConnectionCapabilitiesProvider.c 60c3f8206364740f2293ac2b5e67a9d6fac7416d
src/LMI_IPNetworkConnectionElementCapabilitiesProvider.c 4d4006774b0f38ecdb2c7a27d6ea4947927d17ad
src/LMI_IPNetworkConnectionProvider.c 8eace4b6db6c4441c6f480c7d446c4c2b58abf78
src/LMI_IPProtocolEndpointProvider.c d5a7bed70b5c87978513036df0448496d32af7c8
src/LMI_IPRouteSettingDataProvider.c 9122084e717c41718468cb13e8ca3824345ffbea
src/LMI_IPVersionElementSettingDataProvider.c ea4dc61c341c8bf5711de196e885dea16978d27b
src/LMI_IPVersionSettingDataProvider.c ddfd9715bd0aa6e63836236a95e246443ae16daa
src/LMI_LAGPort8023adProvider.c 8a7ba4309acf40d3575b4c964443ec12c601b0c3
src/LMI_LANEndpointProvider.c ea35f7ca2cc6185ae72d6bfdb5f22458922c28ce
src/LMI_LinkAggregationBindsToProvider.c 6472e37eace1c7a4f9877a22794c73b6cd360c90
src/LMI_LinkAggregationConcreteIdentityProvider.c 393b4601e69d80b045e188fca30f7c298e2f8b8f
src/LMI_LinkAggregator8023adProvider.c f00e7a430bd93aa1374dddc05712644209033697
src/LMI_NetworkDeviceSAPImplementationProvider.c b0e5986b57f05b8c47d96a5a0e7a45d61307c1ee
src/LMI_NetworkElementCapabilitiesProvider.c 639ae7e708a639ffe0a779d789b50c056ff6cd44
src/LMI_NetworkEnabledLogicalElementCapabilitiesProvider.c 234f0a27eee2dbad251a2b67042d044e2fc25d91
src/LMI_NetworkHostedAccessPointProvider.c dc5327099924b66154f56feadd72ab0550ae2727
src/LMI_NetworkRemoteAccessAvailableToElementProvider.c 502470b5f3efeeb36250b2794f144f0821ca3d5b
src/LMI_NetworkRemoteServiceAccessPointProvider.c 4ef64b41fe03831050f932a2b3b69468f173fa68
src/LMI_NetworkSAPSAPDependencyProvider.c 2ab7237d951e3eb216309292d94301dd708b029e
src/LMI_NetworkSystemDeviceProvider.c a160df3d799beb7822f8b1af38d07205f5dfe0f8
src/LMI_NextHopIPRouteProvider.c e890551844f909204f71829582b99d30281d9d73
src/LMI_OrderedIPAssignmentComponentProvider.c e59537e932be64aa7a20809494b0679ce9f7f325
src/LMI_RouteUsesEndpointProvider.c e2af35c9d09c930f2cf521c8c387006828704861
src/LMI_SwitchPortProvider.c 3ca0736848fec498cbbe7d6cc00a9ffa861c0c14
src/LMI_SwitchServiceProvider.c 123965ebab29cc50bd4e0565049cb86996021718
src/LMI_SwitchesAmongProvider.c abe2e69cb3f3b6b98697f8d62cd437485632fe94
src/network.h 27577dd4d8fd7be278decd5e6ae251063935f08f
src/network.c 607bd834709a86c8bfe51ac9122d0842b23b1cd9
src/network_private.h a5c08c3350514816dc859fc9ead09ad422e5bac6
Diff: http://reviewboard-openlmi.rhcloud.com/r/436/diff/
Testing
-------
Thanks,
Radek Novacek
10 years, 10 months
Review Request 432: Hardware: Added system slot provider
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/432/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Hardware: Added system slot provider
New providers:
* LMI_SystemSlotProvider
* LMI_SystemSlotContainerProvider
Diffs
-----
mof/60_LMI_Hardware.mof ed50c347fcbb5f83628d87e5782ad0784ccfcf20
src/hardware/LMI_Hardware.h bb070f32e22ccf70ecd9d1774a1738829e0587b1
src/hardware/LMI_SystemSlotContainerProvider.c PRE-CREATION
src/hardware/LMI_SystemSlotProvider.c PRE-CREATION
src/hardware/dmidecode.h 5423c93a9586360b8593df5f197600b92221928b
src/hardware/dmidecode.c cbee376d675be28813e844e3be4b1b4ca601b438
Diff: http://reviewboard-openlmi.rhcloud.com/r/432/diff/
Testing
-------
Thanks,
Peter Schiffer
10 years, 10 months
Review Request 431: Hardware: Added chassis ports provider
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/431/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Hardware: Added chassis ports provider
New providers:
* LMI_PortPhysicalConnectorProvider
* LMI_PortPhysicalConnectorContainerProvider
Diffs
-----
mof/60_LMI_Hardware.mof 1a9ae4c36df1aac821cb0e075d1463968cdfe9b9
src/hardware/LMI_Hardware.h 2d09c00865a7a5a90f25e0223691bbd2e7527976
src/hardware/LMI_PortPhysicalConnectorContainerProvider.c PRE-CREATION
src/hardware/LMI_PortPhysicalConnectorProvider.c PRE-CREATION
src/hardware/dmidecode.h d3f8bd4b0fa3f4d4788ba1c31f503691b61bbd4b
src/hardware/dmidecode.c 4023cf3d82c30fc7bc562daaa7dc265408696cc9
Diff: http://reviewboard-openlmi.rhcloud.com/r/431/diff/
Testing
-------
Thanks,
Peter Schiffer
10 years, 10 months