Review Request 449: openlmi-networking [5/6] Handle generic device type properly
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/449/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
Handle generic device type properly
Recent NetworkManager (0.9.9) introduced generic device type that is
used for devices that NetworkManager don't manage (like loopback).
This commit also make sure that newly added device type will not crash
the provider.
Diffs
-----
src/ipnetworkconnection.c 21ecd289a7ff3913c906dc1e536343ccfccb1e29
src/network.c 1adcc8054c749bd7efa5713983b4a0c9ddbb3d3c
src/port.c 5f5c27d93d8b78147544d723c5a94cb2be56f609
src/port_nm.c 52ad5332a36e7a9f66344322047473d3596a6300
Diff: http://reviewboard-openlmi.rhcloud.com/r/449/diff/
Testing
-------
Thanks,
Radek Novacek
10 years, 9 months
Review Request 447: openlmi-networking [3/6] test: fix some potential test failures
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/447/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
test: fix some potential test failures
Diffs
-----
test/objects.json 4f4c0faf1da10c8c3298dfa29af90d702a6301c6
test/test_apply_connection.py 5e328039d6b89ae7442e0a92817e069209180812
test/test_base.py a619cd1ff6bb02772faf7a1638ae169d7a12f5bf
test/test_check_doc.py 10ec3306b24aa3dbaf076acdccecfa948ae076bc
test/test_create_destroy_connection.py 6ff246bdaf84cab9046e8353384c0b14fe774472
test/test_indications.py 82238b7232fa555911a276770d6832010b5f4b78
test/test_smash_conformance.py d963ef83b98c15eb4282c46b5466754b50f18af2
Diff: http://reviewboard-openlmi.rhcloud.com/r/447/diff/
Testing
-------
Thanks,
Radek Novacek
10 years, 9 months
Review Request 452: Clean in account [2/2] Account: Use asprintf instead of snprintf
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/452/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Account: Use asprintf instead of snprintf
Signed-off-by: Roman Rakus <rrakus(a)redhat.com>
Diffs
-----
src/account/LMI_AccountManagementServiceProvider.c f4a925e64a207cd266fa74967b17041c8e528d13
src/account/LMI_AccountProvider.c 8eb538b04adbad1f22b852b7c32edd86079ecafe
src/account/LMI_AssignedAccountIdentityProvider.c 323a582217cd1c101863cc489b3e4ee94aa3a4ff
src/account/LMI_AssignedGroupIdentityProvider.c a9037f1bd86a39ef21869796a692a0ec85affb08
src/account/LMI_GroupProvider.c a9c547724ecf8e66f92efb1677ee3b6f348f6051
src/account/LMI_IdentityProvider.c 92c2b0119a3dd81ca62be99c6e09f894f46841cd
src/account/LMI_MemberOfGroupProvider.c dddd2e80952d7a1bedc0a0291ada56b5d7a1aea9
src/account/LMI_ServiceAffectsIdentityProvider.c 64e218b4068c696dbb5479d7e73c2f38b4fc0cb5
Diff: http://reviewboard-openlmi.rhcloud.com/r/452/diff/
Testing
-------
Thanks,
Roman Rakus
10 years, 9 months
Review Request 451: Clean in account [1/2] Account: Use KReturn2 instead of CMReturnWithChars
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/451/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Account: Use KReturn2 instead of CMReturnWithChars
KReturn2 now supports valist so we don't need to use temp variables
Signed-off-by: Roman Rakus <rrakus(a)redhat.com>
Diffs
-----
src/account/LMI_AccountProvider.c 8eb538b04adbad1f22b852b7c32edd86079ecafe
src/account/LMI_GroupProvider.c a9c547724ecf8e66f92efb1677ee3b6f348f6051
src/account/LMI_IdentityProvider.c 92c2b0119a3dd81ca62be99c6e09f894f46841cd
src/account/LMI_MemberOfGroupProvider.c dddd2e80952d7a1bedc0a0291ada56b5d7a1aea9
Diff: http://reviewboard-openlmi.rhcloud.com/r/451/diff/
Testing
-------
Thanks,
Roman Rakus
10 years, 9 months
Review Request 441: indications [1/3] Account: Indication for creating instances
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/441/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Account: Indication for creating instances
Signed-off-by: Roman Rakus <rrakus(a)redhat.com>
Diffs
-----
mof/60_LMI_Account.mof d79db352f5d9b9891530a182f108720dc703e18a
src/account/CMakeLists.txt 38ecd021a011c76a6f964d7b344a092787541b85
src/account/LMI_AccountInstanceCreationIndicationProvider.c PRE-CREATION
src/account/macros.h 80a940089dfe79d8e6bd3cb3af93e84649050e6e
Diff: http://reviewboard-openlmi.rhcloud.com/r/441/diff/
Testing
-------
Thanks,
Roman Rakus
10 years, 9 months