Review Request 466: Hardware: Added pointing device provider
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/466/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Hardware: Added pointing device provider
New provider:
* LMI_PointingDeviceProvider
It currently represents pointing devices on chassis, such as touch pad or track
point.
Diffs
-----
mof/60_LMI_Hardware.mof f4bc7645b3a26702ea484b0a3ef7727b842f8829
src/hardware/LMI_Hardware.h 81881f572ba09e34457ae62677b494b3542ad896
src/hardware/LMI_PointingDeviceProvider.c PRE-CREATION
src/hardware/dmidecode.h 76627af71fccb03e1f28fe2d32e4f6d2947b1dbf
src/hardware/dmidecode.c f29596f8376e1dcce52056876f87fee954372976
Diff: http://reviewboard-openlmi.rhcloud.com/r/466/diff/
Testing
-------
Thanks,
Peter Schiffer
10 years, 9 months
Review Request 461: lmishell, properties access
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/461/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-tools
Description
-------
Honza S.:
In a lmishell script I want to manually loop over all properties and get their values. I can use _LmiInstance.properties() to get list of properties, but there is no way, how to get property values. Either _LmiInstance.properties() should return a dictionary or there should be _LmiInstance.get_property(name) method.
Sample code:
i = c.root.cimv2.LMI_StorageExtent.first_instance()
for p in i.properties:
print p, i.get_property(p)
-----
There is a way, how to get properties:
i = c.root.cimv2.LMI_StorageExtent.first_instance()
for p in i.properties:
print p, getattr(i, p)
^^
Or how to get Names property value:
i.Names
Dunno, if it is a correct (python) way. Maybe it should be switched to a "dictionary style". I used this attitude just because of methods access.
Diffs
-----
cli-tools/lmi/lmi_client_shell.py 54bd8b263002c5df9f3d7dad414e75cae9bc3c41
Diff: http://reviewboard-openlmi.rhcloud.com/r/461/diff/
Testing
-------
Thanks,
Peter Hatina
10 years, 10 months
Review Request 457: openlmi-networking [1/1] Fix memory issues, missing unlocks, etc.
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/457/
-----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
Fix memory issues, missing unlocks, etc.
Fix errors found by clang-analyzer and coverity.
Diffs
-----
src/LMI_EndpointIdentityProvider.c d1ed4247c028086f3700d6c5208b67a25d7867e1
src/LMI_IPAssignmentSettingDataProvider.c 66bdd2e14c632deef5dd1405ae94d5951a4813db
src/LMI_IPNetworkConnectionCapabilitiesProvider.c 3057f20914a783504cbb63e990e2d6907c5093f1
src/LMI_NetworkInstCreationProvider.c d5ac0bd8a4222143526a622f5451b690e8c869ec
src/LMI_NetworkInstDeletionProvider.c 95ab72f61efa4481e060ea41b804ead754a054ae
src/LMI_NetworkInstModificationProvider.c 314e12be6e9ce659f86a48d4c09e214f184a7752
src/LMI_SwitchPortProvider.c d85b4b8c160285c014b244e6eedcc42d1e69cc43
src/LMI_SwitchesAmongProvider.c 83acb72f05507ffcb18b5424e6557b2f779b8ea8
src/network.c 1adcc8054c749bd7efa5713983b4a0c9ddbb3d3c
src/setting_nm.c cf2ef72d45143209dc6a03f038d6655dcc5c01b6
src/unittest/test_network.c c7504993442359b63588b893e6b59dd57204ec11
src/unittest/test_setting.c cf867dd42a08590f6adf684d04d8c9cc79e8bbd1
Diff: http://reviewboard-openlmi.rhcloud.com/r/457/diff/
Testing
-------
Thanks,
Radek Novacek
10 years, 10 months