Re: Review Request 418: openlmi-networking [1/4] Implement NetworkAddresses and MaxSpeed properties of LMI_EthernetPort
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/418/
-----------------------------------------------------------
(Updated May 30, 2013, 10:02 a.m.)
Status
------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
Implement NetworkAddresses and MaxSpeed properties of LMI_EthernetPort
Diffs
-----
mof/LMI_Networking.mof d03d6e1c06c5fe2f17711816ab29c1cef4e91c88
src/LMI_EthernetPortProvider.c 78df2e0f10b478984a5d13dcd020377bd6283603
src/port.h 8558a4e2752f3f12972514d9bae803d03949a201
src/port.c 3d69058c197142bb257d3f6ed6706c44f67b1f02
src/port_nm.c 70f5453fda21bf886451c460f15795588caf9fc4
src/port_private.h fc27956d8d475df355072751d007a3b0dc91534c
Diff: http://reviewboard-openlmi.rhcloud.com/r/418/diff/
Testing
-------
Thanks,
Radek Novacek
10 years, 11 months
Re: Review Request 417: Account [1/1] Account: Correctly handle empty fields in shadow file
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/417/#review499
-----------------------------------------------------------
src/account/LMI_AccountProvider.c
<http://reviewboard-openlmi.rhcloud.com/r/417/#comment302>
Could you create a macro definition for -1 instead of using magic numbers? That way it's clear what you're testing for. Something like
#define SHADOW_VALUE_EMPTY -1
- Stephen Gallagher
On May 28, 2013, 2:42 p.m., Roman Rakus wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/417/
> -----------------------------------------------------------
>
> (Updated May 28, 2013, 2:42 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-providers
>
>
> Description
> -------
>
> Account: Correctly handle empty fields in shadow file
>
> libuser returns -1 for empty fields. Handle the -1 on missing places.
>
> Fixes Ticket #113: LMI_Account instance enumeration fails with "DateTime is out of range"
>
> Signed-off-by: Roman Rakus <rrakus(a)redhat.com>
>
>
> Diffs
> -----
>
> src/account/LMI_AccountProvider.c c4a68f7c71d0f77821bdf95aec7ae60ffae0b455
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/417/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Roman Rakus
>
>
10 years, 11 months
Re: Review Request 420: openlmi-networking [3/4] Rename AddStaticIPRoute to LMI_AddStaticIPRoute
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/420/#review503
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Safranek
On May 29, 2013, 12:55 p.m., Radek Novacek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/420/
> -----------------------------------------------------------
>
> (Updated May 29, 2013, 12:55 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-networking
>
>
> Description
> -------
>
> Rename AddStaticIPRoute to LMI_AddStaticIPRoute
>
> Add the LMI_ prefix to emphasize that it's a custom class.
>
>
> Diffs
> -----
>
> mof/LMI_Networking.mof d03d6e1c06c5fe2f17711816ab29c1cef4e91c88
> src/LMI_IPAssignmentSettingDataProvider.c 538123c0a45deace760eca742acda80028c0d8ae
> test/test_create_destroy_connection.py 39dc2bec3c3bc14bb8833fd9c888d8b3e8caa8a5
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/420/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Radek Novacek
>
>
10 years, 11 months
Re: Review Request 419: openlmi-networking [2/4] Implement some more properties of defined classes
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/419/#review502
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Safranek
On May 29, 2013, 12:55 p.m., Radek Novacek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/419/
> -----------------------------------------------------------
>
> (Updated May 29, 2013, 12:55 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-networking
>
>
> Description
> -------
>
> Implement some more properties of defined classes
>
>
> Diffs
> -----
>
> mof/LMI_Networking.mof d03d6e1c06c5fe2f17711816ab29c1cef4e91c88
> src/LMI_EthernetPortProvider.c 78df2e0f10b478984a5d13dcd020377bd6283603
> src/LMI_IPNetworkConnectionCapabilitiesProvider.c cd5fac1701378399b5a06634ab46aad1a1b91153
> src/LMI_IPNetworkConnectionProvider.c a312e5571db0d7e8867f768b81365708b53d6657
> src/LMI_IPVersionSettingDataProvider.c 79ab767531e768b767c5316b91542d270d9b1918
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/419/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Radek Novacek
>
>
10 years, 11 months
Re: Review Request 418: openlmi-networking [1/4] Implement NetworkAddresses and MaxSpeed properties of LMI_EthernetPort
by Stephen Gallagher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/418/#review501
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Safranek
On May 29, 2013, 12:55 p.m., Radek Novacek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/418/
> -----------------------------------------------------------
>
> (Updated May 29, 2013, 12:55 p.m.)
>
>
> Review request for OpenLMI Developers.
>
>
> Repository: openlmi-networking
>
>
> Description
> -------
>
> Implement NetworkAddresses and MaxSpeed properties of LMI_EthernetPort
>
>
> Diffs
> -----
>
> mof/LMI_Networking.mof d03d6e1c06c5fe2f17711816ab29c1cef4e91c88
> src/LMI_EthernetPortProvider.c 78df2e0f10b478984a5d13dcd020377bd6283603
> src/port.h 8558a4e2752f3f12972514d9bae803d03949a201
> src/port.c 3d69058c197142bb257d3f6ed6706c44f67b1f02
> src/port_nm.c 70f5453fda21bf886451c460f15795588caf9fc4
> src/port_private.h fc27956d8d475df355072751d007a3b0dc91534c
>
> Diff: http://reviewboard-openlmi.rhcloud.com/r/418/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Radek Novacek
>
>
10 years, 11 months