----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/300/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Diffs -----
CMakeLists.txt b42debc577a53ece07682bfbdaeb32cf88919c67 README 7e17e458ef4699a62ec933a6d4a51f35588f97e1 doc/cim-provider-howto.md PRE-CREATION mof/60_LMI_Hardware.mof 3ceb88691d45c6b8f2f0d41a4a5f2464d04ee9df mof/60_LMI_Realmd.mof PRE-CREATION mof/70_LMI_SoftwareIndicationFilters.mof e3af599dbd921ab0224154008aed04027a805a32 openlmi-cimmof PRE-CREATION openlmi-mof-register d7918e0e5b43358428c0b969ea78021e16d853b1 src/CMakeLists.txt 6bf4b8519168a1629faf3e4d0dd5e81435215276 src/hardware/LMI_Hardware.h 19a8ff70decd76916963844dfa2a0098793010b0 src/hardware/LMI_MemoryProvider.c 6c9a2ec1fd0c54a0fd355f32749758f0c9290926 src/hardware/LMI_PhysicalMemoryProvider.c PRE-CREATION src/hardware/LMI_PhysicalMemoryRealizesProvider.c PRE-CREATION src/hardware/LMI_ProcessorCacheMemoryProvider.c 030ddd154c029217bba90b1dcfbfd16b1d436651 src/hardware/LMI_ProcessorCapabilitiesProvider.c c7711242aa14d6ea585eed2f4337f772a2d6a176 src/hardware/LMI_ProcessorChipProvider.c 47ba488995976313c1def5a4269e55b1bbf051c3 src/hardware/LMI_ProcessorChipRealizesProvider.c 6dfd4bfb91bd25b1a4c13d816766ae7b56e5286d src/hardware/LMI_ProcessorElementCapabilitiesProvider.c 322e966103f6e4acc6b69ec7269505bd3c6cff5f src/hardware/LMI_ProcessorProvider.c c14b10568f1296850b6a605c2453e6a40339ea83 src/hardware/dmidecode.h d3320ea5018ff92277760a82b3be24ecdfa050a7 src/hardware/dmidecode.c 367a08c1f2264a186ee45d72da28426c09e54821 src/hardware/sysfs.h 028b55925c7462aa55be1a4fc8cfcf9abf5172e0 src/hardware/sysfs.c d07df71aeb0d44129c9d03ad74c80aa985a9edf6 src/python/openlmi/common/IndicationManager.py ba0919d9c15a1fcced295e41aeaf92ef77ea63b3 src/python/openlmi/common/JobManager.py 5ed783069c7fdd5a0eaa08d346434daab520b7e9 src/realmd/CMakeLists.txt PRE-CREATION src/realmd/LMI_HostedRealmdServiceProvider.c PRE-CREATION src/realmd/LMI_RealmdKerberosRealmProvider.c PRE-CREATION src/realmd/LMI_RealmdRealmProvider.c PRE-CREATION src/realmd/LMI_RealmdServiceProvider.c PRE-CREATION src/realmd/LMI_ServiceAffectsRealmdRealmProvider.c PRE-CREATION src/realmd/README PRE-CREATION src/realmd/VERSION PRE-CREATION src/realmd/doc/class_diagram.svg PRE-CREATION src/realmd/doc/examples/realmd-cim PRE-CREATION src/realmd/rdcp_dbus.h PRE-CREATION src/realmd/rdcp_dbus.c PRE-CREATION src/realmd/rdcp_error.h PRE-CREATION src/realmd/rdcp_error.c PRE-CREATION src/realmd/rdcp_realmdrealm.h PRE-CREATION src/realmd/rdcp_util.h PRE-CREATION src/realmd/rdcp_util.c PRE-CREATION src/realmd/realm-dbus-constants.h PRE-CREATION src/software/openlmi/software/LMI_SoftwareInstallationJob.py ba0867fc70b27a59ad33f31983e7d278f82fb256 src/software/openlmi/software/LMI_SoftwareInstallationService.py f1e0ea71ec1d132c91ad49d86b3dcf9d5d4be139 src/software/openlmi/software/cimom_entry.py ad944c85ce274203a3130a823fc666b7f279c9f5 src/software/openlmi/software/core/Error.py 210c00ef912aca7453437b3eb93f68449684c273 src/software/openlmi/software/core/InstMethodCall.py PRE-CREATION src/software/openlmi/software/core/InstallationJob.py 7b06be2acbab2df92125290759b6552063171f3f src/software/openlmi/software/core/InstallationService.py acc7ca60392f17ba930c74a8b7f07d064ab3b1da src/software/openlmi/software/core/MethodResult.py 723edbba967205f1e5231981fa22559adfcb9c03 src/software/openlmi/software/yumdb/__init__.py 04f21918cdce7aae0e7c474992b53a472bf09ec0 src/software/openlmi/software/yumdb/jobmanager.py 7283d054028b29c0e101a6b0515b42bc3a550317 src/software/openlmi/software/yumdb/jobs.py 84fd3ed5f7333d74528fe1b4757844c070906aa8
Diff: http://reviewboard-openlmi.rhcloud.com/r/300/diff/
Testing -------
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/300/ -----------------------------------------------------------
(Updated May 2, 2013, 1:02 p.m.)
Review request for OpenLMI Developers.
Summary (updated) -----------------
openlmi-software[+CIM_InstMethodCall] support for method parameters and pre/post indications
Repository: openlmi-providers
Description (updated) -------
support for method parameters and pre/post indications
Added input and output parameters to LMI_SoftwareInstallationJob. Added PreCallIndication and PostCallIndication properties to LMI_SoftwareMethodResult containg CIM_InstMethodCall indication instances - that are rather useless but mandatory by Job Control Profile.
Diffs (updated) -----
src/software/openlmi/software/yumdb/jobs.py 84fd3ed5f7333d74528fe1b4757844c070906aa8 src/software/openlmi/software/yumdb/__init__.py 04f21918cdce7aae0e7c474992b53a472bf09ec0 src/software/openlmi/software/core/MethodResult.py 723edbba967205f1e5231981fa22559adfcb9c03 src/software/openlmi/software/core/InstallationService.py acc7ca60392f17ba930c74a8b7f07d064ab3b1da src/software/openlmi/software/core/InstallationJob.py 7b06be2acbab2df92125290759b6552063171f3f src/software/openlmi/software/core/InstMethodCall.py PRE-CREATION src/software/openlmi/software/core/Error.py 210c00ef912aca7453437b3eb93f68449684c273 src/software/openlmi/software/LMI_SoftwareInstallationService.py f1e0ea71ec1d132c91ad49d86b3dcf9d5d4be139
Diff: http://reviewboard-openlmi.rhcloud.com/r/300/diff/
Testing -------
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/300/#review364 -----------------------------------------------------------
src/software/openlmi/software/core/InstMethodCall.py http://reviewboard-openlmi.rhcloud.com/r/300/#comment231
Raising TypeError and ValueError is nice and clean, still, what the caller does with these exceptions? IMHO they are translated to CIMError anyway.
And what "job must be a YumJob" tells the user? IMHO these check could be simple assert().
Feel free to keep the code like it is, it is correct and nice, I'm just wondering.
- Jan Safranek
On May 2, 2013, 3:02 p.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/300/
(Updated May 2, 2013, 3:02 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
support for method parameters and pre/post indications
Added input and output parameters to LMI_SoftwareInstallationJob. Added PreCallIndication and PostCallIndication properties to LMI_SoftwareMethodResult containg CIM_InstMethodCall indication instances - that are rather useless but mandatory by Job Control Profile.
Diffs
src/software/openlmi/software/yumdb/jobs.py 84fd3ed5f7333d74528fe1b4757844c070906aa8 src/software/openlmi/software/yumdb/__init__.py 04f21918cdce7aae0e7c474992b53a472bf09ec0 src/software/openlmi/software/core/MethodResult.py 723edbba967205f1e5231981fa22559adfcb9c03 src/software/openlmi/software/core/InstallationService.py acc7ca60392f17ba930c74a8b7f07d064ab3b1da src/software/openlmi/software/core/InstallationJob.py 7b06be2acbab2df92125290759b6552063171f3f src/software/openlmi/software/core/InstMethodCall.py PRE-CREATION src/software/openlmi/software/core/Error.py 210c00ef912aca7453437b3eb93f68449684c273 src/software/openlmi/software/LMI_SoftwareInstallationService.py f1e0ea71ec1d132c91ad49d86b3dcf9d5d4be139
Diff: http://reviewboard-openlmi.rhcloud.com/r/300/diff/
Testing
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/300/#review366 -----------------------------------------------------------
Ship it!
Ship It!
- Jan Safranek
On May 2, 2013, 3:02 p.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/300/
(Updated May 2, 2013, 3:02 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
support for method parameters and pre/post indications
Added input and output parameters to LMI_SoftwareInstallationJob. Added PreCallIndication and PostCallIndication properties to LMI_SoftwareMethodResult containg CIM_InstMethodCall indication instances - that are rather useless but mandatory by Job Control Profile.
Diffs
src/software/openlmi/software/yumdb/jobs.py 84fd3ed5f7333d74528fe1b4757844c070906aa8 src/software/openlmi/software/yumdb/__init__.py 04f21918cdce7aae0e7c474992b53a472bf09ec0 src/software/openlmi/software/core/MethodResult.py 723edbba967205f1e5231981fa22559adfcb9c03 src/software/openlmi/software/core/InstallationService.py acc7ca60392f17ba930c74a8b7f07d064ab3b1da src/software/openlmi/software/core/InstallationJob.py 7b06be2acbab2df92125290759b6552063171f3f src/software/openlmi/software/core/InstMethodCall.py PRE-CREATION src/software/openlmi/software/core/Error.py 210c00ef912aca7453437b3eb93f68449684c273 src/software/openlmi/software/LMI_SoftwareInstallationService.py f1e0ea71ec1d132c91ad49d86b3dcf9d5d4be139
Diff: http://reviewboard-openlmi.rhcloud.com/r/300/diff/
Testing
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/300/ -----------------------------------------------------------
(Updated May 10, 2013, 11:50 a.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
support for method parameters and pre/post indications
Added input and output parameters to LMI_SoftwareInstallationJob. Added PreCallIndication and PostCallIndication properties to LMI_SoftwareMethodResult containg CIM_InstMethodCall indication instances - that are rather useless but mandatory by Job Control Profile.
Diffs -----
src/software/openlmi/software/yumdb/jobs.py 84fd3ed5f7333d74528fe1b4757844c070906aa8 src/software/openlmi/software/yumdb/__init__.py 04f21918cdce7aae0e7c474992b53a472bf09ec0 src/software/openlmi/software/core/MethodResult.py 723edbba967205f1e5231981fa22559adfcb9c03 src/software/openlmi/software/core/InstallationService.py acc7ca60392f17ba930c74a8b7f07d064ab3b1da src/software/openlmi/software/core/InstallationJob.py 7b06be2acbab2df92125290759b6552063171f3f src/software/openlmi/software/core/InstMethodCall.py PRE-CREATION src/software/openlmi/software/core/Error.py 210c00ef912aca7453437b3eb93f68449684c273 src/software/openlmi/software/LMI_SoftwareInstallationService.py f1e0ea71ec1d132c91ad49d86b3dcf9d5d4be139
Diff: http://reviewboard-openlmi.rhcloud.com/r/300/diff/
Testing -------
Thanks,
Michal Minar
openlmi-devel@lists.fedorahosted.org