-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/247/#review279
-----------------------------------------------------------
Ship it!
Apart from few minor issues, the patch looks fine.
src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
<
http://reviewboard-openlmi.rhcloud.com/r/247/#comment166>
debug print?
src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
<
http://reviewboard-openlmi.rhcloud.com/r/247/#comment167>
free id
src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
<
http://reviewboard-openlmi.rhcloud.com/r/247/#comment168>
free setting
- Jan Safranek
On April 19, 2013, 2:41 p.m., Radek Novacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/247/
-----------------------------------------------------------
(Updated April 19, 2013, 2:41 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
Support for IPAssignmentSettingData modification
ModifyInstance implementation for LMI_IPAssignmentSettingData and
LMI_ExtendedStaticIPAssignmentSettingData.
Diffs
-----
src/LMI_ExtendedStaticIPAssignmentSettingDataProvider.c
c17b93921cc035352be7e733760d34a03f29a30a
src/LMI_IPAssignmentSettingDataProvider.c 96b70f67db210023e939dcfe2a20ba598802bc46
Diff:
http://reviewboard-openlmi.rhcloud.com/r/247/diff/
Testing
-------
Thanks,
Radek Novacek