-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/879/#review1215
-----------------------------------------------------------
Ship it!
Those are just nitpicks, feel free to ship it.
src/logicalfile/doc/source/conf.py
<
http://reviewboard-openlmi.rhcloud.com/r/879/#comment752>
Shouldn't be version 0.2 to match version of providers?
src/logicalfile/doc/source/usage.rst
<
http://reviewboard-openlmi.rhcloud.com/r/879/#comment753>
EnumInstances is just a shortcut used by konkret. Official name is
EnumerateInstances.
src/logicalfile/doc/source/usage.rst
<
http://reviewboard-openlmi.rhcloud.com/r/879/#comment754>
Does this property really need to be used? User might not know whether is the home
directory local.
src/logicalfile/doc/source/usage.rst
<
http://reviewboard-openlmi.rhcloud.com/r/879/#comment755>
Use first_associator(...) instead of associators(...)[0], it's more readable.
- Radek Novacek
On Sept. 19, 2013, 2:09 p.m., Jan Synacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/879/
-----------------------------------------------------------
(Updated Sept. 19, 2013, 2:09 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
logicalfile: add documentation
Diffs
-----
src/logicalfile/doc/Makefile PRE-CREATION
src/logicalfile/doc/source/conf.py PRE-CREATION
src/logicalfile/doc/source/index.rst PRE-CREATION
src/logicalfile/doc/source/mof/Makefile PRE-CREATION
src/logicalfile/doc/source/mof/header.txt PRE-CREATION
src/logicalfile/doc/source/usage.rst PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/879/diff/
Testing
-------
Thanks,
Jan Synacek
_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews