Send openlmi-reviews mailing list submissions to
openlmi-reviews(a)lists.fedorahosted.org
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews
or, via email, send a message with subject or body 'help' to
openlmi-reviews-request(a)lists.fedorahosted.org
You can reach the person managing the list at
openlmi-reviews-owner(a)lists.fedorahosted.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of openlmi-reviews digest..."
Today's Topics:
1. Re: Review Request 419: openlmi-networking [2/4] Implement
some more properties of defined classes (Jan Safranek)
2. Re: Review Request 420: openlmi-networking [3/4] Rename
AddStaticIPRoute to LMI_AddStaticIPRoute (Jan Safranek)
3. Re: Review Request 421: openlmi-networking [4/4] Fix
documentation to use new settings API (Jan Safranek)
4. Re: Review Request 417: Account [1/1] Account: Correctly
handle empty fields in shadow file (Roman Rakus)
----------------------------------------------------------------------
Message: 1
Date: Thu, 30 May 2013 07:58:42 -0000
From: Jan Safranek <reviewboard(a)gallagherhome.com>
To: "OpenLMI Developers" <openlmi-reviews(a)lists.fedorahosted.org>,
"Jan Safranek" <jsafrane(a)redhat.com>, "Radek Novacek"
<rnovacek(a)redhat.com>
Subject: Re: Review Request 419: openlmi-networking [2/4] Implement
some more properties of defined classes
Message-ID:
<20130530075842.11235.31654(a)ex-std-node147.prod.rhcloud.com>
Content-Type: text/plain; charset="utf-8"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/419/#review502
-----------------------------------------------------------
Ship it!
Ship It!
- Jan Safranek
On May 29, 2013, 12:55 p.m., Radek Novacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/419/
-----------------------------------------------------------
(Updated May 29, 2013, 12:55 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
-------
Implement some more properties of defined classes
Diffs
-----
mof/LMI_Networking.mof d03d6e1c06c5fe2f17711816ab29c1cef4e91c88
src/LMI_EthernetPortProvider.c 78df2e0f10b478984a5d13dcd020377bd6283603
src/LMI_IPNetworkConnectionCapabilitiesProvider.c
cd5fac1701378399b5a06634ab46aad1a1b91153
src/LMI_IPNetworkConnectionProvider.c a312e5571db0d7e8867f768b81365708b53d6657
src/LMI_IPVersionSettingDataProvider.c 79ab767531e768b767c5316b91542d270d9b1918
Diff:
http://reviewboard-openlmi.rhcloud.com/r/419/diff/
Testing
-------
Thanks,
Radek Novacek