----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/375/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Move master connection id and slave type out of ConnectionPriv
There is no reason to have it in private structure, moved to public Connection structure.
Diffs -----
src/connection.h 42db8f811bdc3e6131b90f3c575506b8be89900b src/connection.c c38717cfcc747ac05a8e78ec4371a7e91775ad7b src/connection_nm.c a94dd68de117df08f058e48abd41722578493b9b src/connection_private.h 4e411195959700129d13f3329b708eb6535c36db src/unittest/test_connection.c 9b7890a3f0babc24de7a9273a1d1cb5190e0cf1e
Diff: http://reviewboard-openlmi.rhcloud.com/r/375/diff/
Testing -------
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/375/#review457 -----------------------------------------------------------
Ship it!
Ship It!
- Jan Safranek
On May 20, 2013, 3:39 p.m., Radek Novacek wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/375/
(Updated May 20, 2013, 3:39 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description
Move master connection id and slave type out of ConnectionPriv
There is no reason to have it in private structure, moved to public Connection structure.
Diffs
src/connection.h 42db8f811bdc3e6131b90f3c575506b8be89900b src/connection.c c38717cfcc747ac05a8e78ec4371a7e91775ad7b src/connection_nm.c a94dd68de117df08f058e48abd41722578493b9b src/connection_private.h 4e411195959700129d13f3329b708eb6535c36db src/unittest/test_connection.c 9b7890a3f0babc24de7a9273a1d1cb5190e0cf1e
Diff: http://reviewboard-openlmi.rhcloud.com/r/375/diff/
Testing
Thanks,
Radek Novacek
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/375/ -----------------------------------------------------------
(Updated May 23, 2013, 9:47 a.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-networking
Description -------
Move master connection id and slave type out of ConnectionPriv
There is no reason to have it in private structure, moved to public Connection structure.
Diffs -----
src/connection.h 42db8f811bdc3e6131b90f3c575506b8be89900b src/connection.c c38717cfcc747ac05a8e78ec4371a7e91775ad7b src/connection_nm.c a94dd68de117df08f058e48abd41722578493b9b src/connection_private.h 4e411195959700129d13f3329b708eb6535c36db src/unittest/test_connection.c 9b7890a3f0babc24de7a9273a1d1cb5190e0cf1e
Diff: http://reviewboard-openlmi.rhcloud.com/r/375/diff/
Testing -------
Thanks,
Radek Novacek
openlmi-devel@lists.fedorahosted.org