----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/334/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
added implementation for verification classes
implemented: LMI_SoftwareIdentityFileCheck LMI_SoftwareIdentityChecks
Diffs -----
mof/LMI_Software.reg 655d4b988dee77b5c4d35fb22985d340a5e11162 src/software/openlmi/software/LMI_SoftwareIdentityChecks.py PRE-CREATION src/software/openlmi/software/LMI_SoftwareIdentityFileCheck.py PRE-CREATION src/software/openlmi/software/cimom_entry.py 70df0713ae339f84943d9c8751bef5b0b03bd864 src/software/openlmi/software/core/IdentityFileCheck.py PRE-CREATION src/software/openlmi/software/yumdb/__init__.py ccb4360dc49ccaebe293916f86a074bffc32b0d7 src/software/openlmi/software/yumdb/errors.py a6824b9be001989adf7c5896dce0477517fa8951 src/software/openlmi/software/yumdb/jobs.py 5195f5041f1a9f809d1fadec1749a20d17606b58 src/software/openlmi/software/yumdb/packagecheck.py 4cdc5eed89df1647340dde5060bbaeee037ea3c2 src/software/openlmi/software/yumdb/process.py 8ae6e46b0f5f9615afaa9654afa2316f99fc02b6
Diff: http://reviewboard-openlmi.rhcloud.com/r/334/diff/
Testing -------
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/334/#review394 -----------------------------------------------------------
src/software/openlmi/software/LMI_SoftwareIdentityChecks.py http://reviewboard-openlmi.rhcloud.com/r/334/#comment243
happy new year! (applies to all files)
src/software/openlmi/software/LMI_SoftwareIdentityFileCheck.py http://reviewboard-openlmi.rhcloud.com/r/334/#comment244
magic numbers
- Jan Safranek
On May 10, 2013, 4:27 p.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/334/
(Updated May 10, 2013, 4:27 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
added implementation for verification classes
implemented: LMI_SoftwareIdentityFileCheck LMI_SoftwareIdentityChecks
Diffs
mof/LMI_Software.reg 655d4b988dee77b5c4d35fb22985d340a5e11162 src/software/openlmi/software/LMI_SoftwareIdentityChecks.py PRE-CREATION src/software/openlmi/software/LMI_SoftwareIdentityFileCheck.py PRE-CREATION src/software/openlmi/software/cimom_entry.py 70df0713ae339f84943d9c8751bef5b0b03bd864 src/software/openlmi/software/core/IdentityFileCheck.py PRE-CREATION src/software/openlmi/software/yumdb/__init__.py ccb4360dc49ccaebe293916f86a074bffc32b0d7 src/software/openlmi/software/yumdb/errors.py a6824b9be001989adf7c5896dce0477517fa8951 src/software/openlmi/software/yumdb/jobs.py 5195f5041f1a9f809d1fadec1749a20d17606b58 src/software/openlmi/software/yumdb/packagecheck.py 4cdc5eed89df1647340dde5060bbaeee037ea3c2 src/software/openlmi/software/yumdb/process.py 8ae6e46b0f5f9615afaa9654afa2316f99fc02b6
Diff: http://reviewboard-openlmi.rhcloud.com/r/334/diff/
Testing
Thanks,
Michal Minar
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/334/#review476 -----------------------------------------------------------
Ship it!
Apart from the minor issues, the patch looks ok.
- Jan Safranek
On May 10, 2013, 4:27 p.m., Michal Minar wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/334/
(Updated May 10, 2013, 4:27 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
added implementation for verification classes
implemented: LMI_SoftwareIdentityFileCheck LMI_SoftwareIdentityChecks
Diffs
mof/LMI_Software.reg 655d4b988dee77b5c4d35fb22985d340a5e11162 src/software/openlmi/software/LMI_SoftwareIdentityChecks.py PRE-CREATION src/software/openlmi/software/LMI_SoftwareIdentityFileCheck.py PRE-CREATION src/software/openlmi/software/cimom_entry.py 70df0713ae339f84943d9c8751bef5b0b03bd864 src/software/openlmi/software/core/IdentityFileCheck.py PRE-CREATION src/software/openlmi/software/yumdb/__init__.py ccb4360dc49ccaebe293916f86a074bffc32b0d7 src/software/openlmi/software/yumdb/errors.py a6824b9be001989adf7c5896dce0477517fa8951 src/software/openlmi/software/yumdb/jobs.py 5195f5041f1a9f809d1fadec1749a20d17606b58 src/software/openlmi/software/yumdb/packagecheck.py 4cdc5eed89df1647340dde5060bbaeee037ea3c2 src/software/openlmi/software/yumdb/process.py 8ae6e46b0f5f9615afaa9654afa2316f99fc02b6
Diff: http://reviewboard-openlmi.rhcloud.com/r/334/diff/
Testing
Thanks,
Michal Minar
openlmi-devel@lists.fedorahosted.org