-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/670/#review848
-----------------------------------------------------------
openlmi-mof-register
<
http://reviewboard-openlmi.rhcloud.com/r/670/#comment460>
I don't like this approach either.
I think it's enough to do this:
1) log "Going to do something"
2) normal command execution
3) store return value if necessary
But ok, let it go...
openlmi-mof-register
<
http://reviewboard-openlmi.rhcloud.com/r/670/#comment459>
It looks ugly.
log "COMMAND: " 'cat "$reg" | ...'
if the commands and/or parameters don't have single quotes quoting, you can simple
copy&paste and encapsulate in single quotes.
Anyway, isn't better to log message like "registering mof file"?
- Roman Rakus
On Aug. 1, 2013, 2:37 p.m., Radek Novacek wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/670/
-----------------------------------------------------------
(Updated Aug. 1, 2013, 2:37 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
Add logging to the openlmi-mof-register script
Each command in the registration script is now logged into
/var/log/openlmi-install.log file.
Diffs
-----
openlmi-mof-register 4e60e31786e22b063e4c3a42116e05038f5275c3
openlmi-providers.spec 0552a8cc01c8c3979a2304463f0a663fcc993a95
Diff:
http://reviewboard-openlmi.rhcloud.com/r/670/diff/
Testing
-------
Thanks,
Radek Novacek
_______________________________________________
openlmi-reviews mailing list
openlmi-reviews(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews