On April 23, 2013, 3 p.m., Radek Novacek wrote:
> src/realmd/CMakeLists.txt, line 20
>
<
http://reviewboard-openlmi.rhcloud.com/r/252/diff/1/?file=1374#file1374li...
>
> Why is it here? -Wall CFlag is already specified in top-level CMakeLists.txt.
It's not there any more.
On April 23, 2013, 3 p.m., Radek Novacek wrote:
> src/realmd/CMakeLists.txt, line 33
>
<
http://reviewboard-openlmi.rhcloud.com/r/252/diff/1/?file=1374#file1374li...
>
> The FIXME seems not valid any more.
...and has been removed too.
On April 23, 2013, 3 p.m., Radek Novacek wrote:
> src/realmd/rdcp_dbus.c, lines 120-131
>
<
http://reviewboard-openlmi.rhcloud.com/r/252/diff/1/?file=1385#file1385li...
>
> This code don't follow coding conventions:
>
>
https://fedorahosted.org/openlmi/wiki/CodingConventions
>
> Please reformat this file using 4 space indentation.
Done.
On April 23, 2013, 3 p.m., Radek Novacek wrote:
> src/realmd/README, line 1
>
<
http://reviewboard-openlmi.rhcloud.com/r/252/diff/1/?file=1380#file1380li...
>
> Most of this document should be merged to top-level readme, only parts related
to Realmd provider should be here.
I have merged the "Development tips" section to the root-level README, added
some RealmD description, and left only FAQ and TODO sections in the RealmD specific
document.
- Tomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/252/#review287
-----------------------------------------------------------
On April 23, 2013, 10:14 a.m., Tomas Smetana wrote:
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/252/
-----------------------------------------------------------
(Updated April 23, 2013, 10:14 a.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
-------
This is the John Dennis' RealmD provider merged into the openlmi-providers tree. I
have not included the tools scripts and left out the spec file. I had to also add
LMI_RealmdService_ChangeAffectedElementsAssignedSequence() function stub to avoid linker
error with --no-undefined.
Please let me know if this is OK.
Diffs
-----
CMakeLists.txt b42debc577a53ece07682bfbdaeb32cf88919c67
mof/LMI_Realmd.mof PRE-CREATION
src/CMakeLists.txt 6bf4b8519168a1629faf3e4d0dd5e81435215276
src/realmd/CMakeLists.txt PRE-CREATION
src/realmd/LMI_HostedRealmdServiceProvider.c PRE-CREATION
src/realmd/LMI_RealmdKerberosRealmProvider.c PRE-CREATION
src/realmd/LMI_RealmdRealmProvider.c PRE-CREATION
src/realmd/LMI_RealmdServiceProvider.c PRE-CREATION
src/realmd/LMI_ServiceAffectsRealmdRealmProvider.c PRE-CREATION
src/realmd/README PRE-CREATION
src/realmd/VERSION PRE-CREATION
src/realmd/doc/class_diagram.svg PRE-CREATION
src/realmd/doc/examples/realmd-cim PRE-CREATION
src/realmd/rdcp_dbus.h PRE-CREATION
src/realmd/rdcp_dbus.c PRE-CREATION
src/realmd/rdcp_error.h PRE-CREATION
src/realmd/rdcp_error.c PRE-CREATION
src/realmd/rdcp_realmdrealm.h PRE-CREATION
src/realmd/rdcp_util.h PRE-CREATION
src/realmd/rdcp_util.c PRE-CREATION
src/realmd/realm-dbus-constants.h PRE-CREATION
Diff:
http://reviewboard-openlmi.rhcloud.com/r/252/diff/
Testing
-------
Thanks,
Tomas Smetana