----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/306/ -----------------------------------------------------------
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Hardware: Better support for multi CPU systems and kvm guests.
Changes: * Fixed problem when CPU ID from dmidecode is not unique * Use cache info from sysfs if dmi cpu info is available, but not dmi cache * When using sysfs cache, create all caches for every CPU * Fixed physical memory tag when serial number field is missing in dmidecode output * Tiny clean-up
Hardware provider was tested in kvm guest with pegasus and this patch is result of the test. Now, thanks to the all fallback options, hardware provider works fine in this environment with and without selinux enabled.
Diffs -----
src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c 3d06a65f7d24423400384f6bbfb70ecd8280319b src/hardware/LMI_ProcessorProvider.c d96c679cfa049b3a936f000f267f06f3f25071bf src/hardware/dmidecode.c dfff7e3cdc73230cea5b8c6e2ace25905aec5a51 src/hardware/sysfs.h 297a1a74077715295e55bd4fbe3742c6ec20d6e1 src/hardware/sysfs.c 80d360e43d31a2b52fee7cc5f897d7cee8600081 src/hardware/utils.h 933c0427b127c8658b98b4b07ca06a2c9125c48a src/hardware/utils.c 8c1b63ea1ea475d0deafa66e2f5b95c06ba3f146
Diff: http://reviewboard-openlmi.rhcloud.com/r/306/diff/
Testing -------
Thanks,
Peter Schiffer
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/306/#review378 -----------------------------------------------------------
Ship it!
Ship It!
- Radek Novacek
On May 7, 2013, 8:09 p.m., Peter Schiffer wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/306/
(Updated May 7, 2013, 8:09 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Hardware: Better support for multi CPU systems and kvm guests.
Changes:
- Fixed problem when CPU ID from dmidecode is not unique
- Use cache info from sysfs if dmi cpu info is available, but not dmi cache
- When using sysfs cache, create all caches for every CPU
- Fixed physical memory tag when serial number field is missing in dmidecode output
- Tiny clean-up
Hardware provider was tested in kvm guest with pegasus and this patch is result of the test. Now, thanks to the all fallback options, hardware provider works fine in this environment with and without selinux enabled.
Diffs
src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c 3d06a65f7d24423400384f6bbfb70ecd8280319b src/hardware/LMI_ProcessorProvider.c d96c679cfa049b3a936f000f267f06f3f25071bf src/hardware/dmidecode.c dfff7e3cdc73230cea5b8c6e2ace25905aec5a51 src/hardware/sysfs.h 297a1a74077715295e55bd4fbe3742c6ec20d6e1 src/hardware/sysfs.c 80d360e43d31a2b52fee7cc5f897d7cee8600081 src/hardware/utils.h 933c0427b127c8658b98b4b07ca06a2c9125c48a src/hardware/utils.c 8c1b63ea1ea475d0deafa66e2f5b95c06ba3f146
Diff: http://reviewboard-openlmi.rhcloud.com/r/306/diff/
Testing
Thanks,
Peter Schiffer
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/306/ -----------------------------------------------------------
(Updated May 13, 2013, 1:03 p.m.)
Status ------
This change has been marked as submitted.
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description -------
Hardware: Better support for multi CPU systems and kvm guests.
Changes: * Fixed problem when CPU ID from dmidecode is not unique * Use cache info from sysfs if dmi cpu info is available, but not dmi cache * When using sysfs cache, create all caches for every CPU * Fixed physical memory tag when serial number field is missing in dmidecode output * Tiny clean-up
Hardware provider was tested in kvm guest with pegasus and this patch is result of the test. Now, thanks to the all fallback options, hardware provider works fine in this environment with and without selinux enabled.
Diffs -----
src/hardware/LMI_AssociatedProcessorCacheMemoryProvider.c 3d06a65f7d24423400384f6bbfb70ecd8280319b src/hardware/LMI_ProcessorProvider.c d96c679cfa049b3a936f000f267f06f3f25071bf src/hardware/dmidecode.c dfff7e3cdc73230cea5b8c6e2ace25905aec5a51 src/hardware/sysfs.h 297a1a74077715295e55bd4fbe3742c6ec20d6e1 src/hardware/sysfs.c 80d360e43d31a2b52fee7cc5f897d7cee8600081 src/hardware/utils.h 933c0427b127c8658b98b4b07ca06a2c9125c48a src/hardware/utils.c 8c1b63ea1ea475d0deafa66e2f5b95c06ba3f146
Diff: http://reviewboard-openlmi.rhcloud.com/r/306/diff/
Testing -------
Thanks,
Peter Schiffer
openlmi-devel@lists.fedorahosted.org