Send openlmi-reviews mailing list submissions to openlmi-reviews@lists.fedorahosted.org
To subscribe or unsubscribe via the World Wide Web, visit https://lists.fedorahosted.org/mailman/listinfo/openlmi-reviews or, via email, send a message with subject or body 'help' to openlmi-reviews-request@lists.fedorahosted.org
You can reach the person managing the list at openlmi-reviews-owner@lists.fedorahosted.org
When replying, please edit your Subject line so it is more specific than "Re: Contents of openlmi-reviews digest..."
Today's Topics:
1. Re: Review Request 417: Account [1/1] Account: Correctly handle empty fields in shadow file (Stephen Gallagher) 2. Re: Review Request 423: [1/1] Add mounting documentation for admins. (Jan Safranek) 3. Re: Review Request 418: openlmi-networking [1/4] Implement NetworkAddresses and MaxSpeed properties of LMI_EthernetPort (Jan Safranek)
----------------------------------------------------------------------
Message: 1 Date: Wed, 29 May 2013 19:37:41 -0000 From: Stephen Gallagher reviewboard@gallagherhome.com To: "OpenLMI Developers" openlmi-reviews@lists.fedorahosted.org, "Stephen Gallagher" sgallagh@fedoraproject.org, "Roman Rakus" rrakus@redhat.com Subject: Re: Review Request 417: Account [1/1] Account: Correctly handle empty fields in shadow file Message-ID: 20130529193741.11235.9372@ex-std-node147.prod.rhcloud.com Content-Type: text/plain; charset="utf-8"
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/417/#review499 -----------------------------------------------------------
src/account/LMI_AccountProvider.c http://reviewboard-openlmi.rhcloud.com/r/417/#comment302
Could you create a macro definition for -1 instead of using magic numbers? That way it's clear what you're testing for. Something like
#define SHADOW_VALUE_EMPTY -1
- Stephen Gallagher
On May 28, 2013, 2:42 p.m., Roman Rakus wrote:
This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/417/
(Updated May 28, 2013, 2:42 p.m.)
Review request for OpenLMI Developers.
Repository: openlmi-providers
Description
Account: Correctly handle empty fields in shadow file
libuser returns -1 for empty fields. Handle the -1 on missing places.
Fixes Ticket #113: LMI_Account instance enumeration fails with "DateTime is out of range"
Signed-off-by: Roman Rakus rrakus@redhat.com
Diffs
src/account/LMI_AccountProvider.c c4a68f7c71d0f77821bdf95aec7ae60ffae0b455
Diff: http://reviewboard-openlmi.rhcloud.com/r/417/diff/
Testing
Thanks,
Roman Rakus