This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/344/

src/fan/LMI_FanAssociatedSensorProvider.c (Diff revision 1)
static CMPIStatus LMI_FanAssociatedSensorEnumInstances(
90
        KReturnInstance(cr, w);
91
        status = __KReturnInstance((cr), &(w).__base);
I've recently added LMI_ReturnInstance macro that returns boolean (false if instance can't be returned). Could you please use it here?

https://reviewboard-openlmi.rhcloud.com/r/359/diff/#index_header

- Radek


On May 13th, 2013, 4:58 p.m. CEST, Stephen Gallagher wrote:

Review request for OpenLMI Developers.
By Stephen Gallagher.

Updated May 13, 2013, 4:58 p.m.

Repository: openlmi-providers

Description

Fix memory leaks

Fixes Coverity issues:
 * 10153
 * 10154
 * 10155

Testing

Compilation test only.

Diffs

  • src/fan/LMI_FanAssociatedSensorProvider.c (b462e83d5f5f353a0e09dfb8af80babe5b8f83a6)
  • src/fan/LMI_FanProvider.c (26af16ea3c119c4ea9fd8812e5b8cf9ed5007347)
  • src/fan/LMI_FanSensorProvider.c (e63d266260db54b5a7b779722b6487f2f03d7776)

View Diff