This is an automatically generated e-mail. To reply, visit: http://reviewboard-openlmi.rhcloud.com/r/241/

Ship it!

Ship It!

- Jan


On April 23rd, 2013, 4:05 p.m. CEST, Michal Minar wrote:

Review request for OpenLMI Developers.
By Michal Minar.

Updated April 23, 2013, 4:05 p.m.

Repository: openlmi-providers

Description

modified indication filters
    
And moved software static filters to shared JobManager.
    
Indication filters now reflect the name of indication class, which is
instrumented by particular provider. This ensures, that cimom knows,
which provider to call and does not bother the others. So instead of
selecting indication instances from general class CIM_InstModification,
it will be LMI_SoftwareInstModification. This is a common pattern for
indication queries.
    
Avoided another shortcoming of sfcbmof parser:
  /* comment */ something useful is also ignored :-(
    
Static filters of JobManager made more generic for any provider
to use. Software jobmanager is now using them. This reduces redundation
of code.

Diffs

  • mof/70_LMI_SoftwareIndicationFilters.mof (e3af599dbd921ab0224154008aed04027a805a32)
  • src/python/openlmi/common/IndicationManager.py (ba0919d9c15a1fcced295e41aeaf92ef77ea63b3)
  • src/python/openlmi/common/JobManager.py (5ed783069c7fdd5a0eaa08d346434daab520b7e9)
  • src/software/openlmi/software/cimom_entry.py (ad944c85ce274203a3130a823fc666b7f279c9f5)
  • src/software/openlmi/software/yumdb/jobmanager.py (7283d054028b29c0e101a6b0515b42bc3a550317)

View Diff