On Sun, Aug 31, 2008 at 5:39 PM, Martin Langhoff martin.langhoff@gmail.com wrote:
On Sun, Aug 31, 2008 at 4:28 AM, Robin Norwood robin.norwood@gmail.com wrote:
Yeah, I can confirm that fakechroot's getpeername() is the problem. If I remove getpeername from fakechroot [1], then I get a fakechroot that works with your test [2]. Obviously we need to instead sort out the parameters to match the system getpeername like rsync does. Not really my area of expertise, but I can file a bug in RH bugzilla for fakechroot when I get back. Got to run, now.
Thanks! From what I see in your patch, you're working around the problem by removing the local implementation of getpeername() so yes, I agree we'll want to see what upstream says about a proper fix.
I'm not versed in the semantics of getpeername() so can't suggest anything smart at the moment.
In the meantime, I'll use your package for testing and try to find out how serious it is that getpeername() gets through unwrapped.
Check the bug again, Axel added what I think is the correct fix. He's waiting of a response from upstream, but we should have the fix soon.
https://bugzilla.redhat.com/show_bug.cgi?id=460753
http://rnorwood.fedorapeople.org/fakechroot-2.8-13.fc9.4.i386.rpm
Is the one I built with Axel's patch, and it seems to work fine for me. Note that I bumped the release to the right of the dist tag, so when axel released -14 (or whatever), upgrades should work.
-RN