Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: virt-top exits sometimes when the window is resized
https://bugzilla.redhat.com/show_bug.cgi?id=568172
Summary: virt-top exits sometimes when the window is resized Product: Red Hat Enterprise Linux 6 Version: 6.0 Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: libvirt AssignedTo: veillard@redhat.com ReportedBy: rjones@redhat.com QAContact: virt-bugs@redhat.com CC: veillard@redhat.com, berrange@redhat.com, rjones@redhat.com, itamar@ispbrasil.com.br, clalance@redhat.com, xen-maint@redhat.com, crobinso@redhat.com, fedora-virt-maint@redhat.com, fedora-ocaml-list@redhat.com, jforbes@redhat.com Depends on: 567931 Group: rhel_beta Classification: Red Hat Target Release: --- Clone Of: 567931
+++ This bug was initially created as a clone of Bug #567931 +++
Description of problem:
virt-top exits sometimes (clean exit with code 1, not a segfault) when the window is resized.
Version-Release number of selected component (if applicable):
virt-top-1.0.4-3.fc13.x86_64 Also observed with the Debian virt-top package.
How reproducible:
Sometimes.
Steps to Reproduce: 1. sudo virt-top -d 0.1 --debug /tmp/debug 2. Resize the window aggressively. 3.
Actual results:
Occasionally virt-top exits.
Expected results:
Should not exit.
Additional info:
Original report: http://rwmj.wordpress.com/2010/02/23/virt-top-is-in-debian/#comment-1256
--- Additional comment from rjones@redhat.com on 2010-02-24 06:45:55 EST ---
This bug is quite hard to reproduce anyway, but it seems like it doesn't happen at all when virt-top is run under gdb. Possibly gdb alters the way that signals are delivered.
--- Additional comment from rjones@redhat.com on 2010-02-24 06:50:03 EST ---
I think this is actually a libvirt bug. The strace output when it exits is:
18863 rt_sigaction(SIGTSTP, {0x3e77e192f0, [], SA_RESTORER|SA_RESTART, 0x3e75a337d0}, NULL, 8) = 0 18863 stat("/etc/localtime", {st_mode=S_IFREG|0644, st_size=3661, ...}) = 0 18863 poll([{fd=3, events=POLLOUT}, {fd=4, events=POLLIN}], 2, -1) = 1 ([{fd=3, revents=POLLOUT}]) 18863 sendto(3, "\0\0\0\34 \0\200\206\0\0\0\1\0\0\0003\0\0\0\0\0\0\0r\0\0\0\0", 28, 0, NULL, 0) = 28 18863 poll([{fd=3, events=POLLIN}, {fd=4, events=POLLIN}], 2, -1) = 1 ([{fd=3, revents=POLLIN}]) 18863 recvfrom(3, "\0\0\1h", 4, 0, NULL, NULL) = 4 18863 recvfrom(3, " \0\200\206\0\0\0\1\0\0\0\25\0\0\0\1\0\0\0q\0\0\0\0\0\0\0\21\0\0\0\21RHEL6200910210x32\0\0\0\0\0\0\vTmpBZ552994\0\0\0\0\21RHEL6201002033x64\0\0\0\0\0\0\nDebian5x64\0\0\0\0\0\fUbuntu910x64\0\0\0\16RHEL6Alpha3x64\0\0\0\0\0\rRHEL54Betax64\0\0\0\0\0\0\6F10x32\0\0\0\0\0\nCentOS5x32\0\0\0\0\0\rF13Rawhidex64\0\0\0\0\0\0\16TmpDebFirewall\0\0\0\0\0\rF12x64preview\0\0\0\0\0\0\nWin2003x32\0\0\0\0\0\7VSphere\0\0\0\0\vWindows7x32\0\0\0\0\vWindows7x64\0\0\0\0\vFreeBSD8x64\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", 356, 0, NULL, NULL) = 356 18863 write(2, "libvir: Remote error : no call waiting for reply with serial 113\n", 65) = 65 18863 write(1, "\33[17;1H\33[2J\33[?47l\0338\r\33[?1l\33>", 27) = 27 18863 ioctl(1, SNDCTL_TMR_STOP or TCSETSW, {B9600 opost isig icanon echo ...}) = 0 18863 write(2, "libvirt: VIR_ERR_RPC: VIR_FROM_REMOTE: no call waiting for reply with serial 113\n", 81) = 81 18863 exit_group(1) = ?
I wonder if this is a regression (see bug 484414).
My libvirt version is: libvirt-0.7.5-3.fc13.x86_64
--- Additional comment from rjones@redhat.com on 2010-02-24 06:52:40 EST ---
Also occurs with libvirt-0.7.6-1.fc13.x86_64
The strace this time is roughly the same:
18952 recvfrom(3, "\0\0\1h", 4, 0, NULL, NULL) = 4 18952 recvfrom(3, " \0\200\206\0\0\0\1\0\0\0\25\0\0\0\1\0\0\6O\0\0\0\0\0\0\0\21\0\0\0\21RHEL6200910210x32\0\0\0\0\0\0\vTmpBZ552994\0\0\0\0\21RHEL6201002033x64\0\0\0\0\0\0\nDebian5x64\0\0\0\0\0\fUbuntu910x64\0\0\0\16RHEL6Alpha3x64\0\0\0\0\0\rRHEL54Betax64\0\0\0\0\0\0\6F10x32\0\0\0\0\0\nCentOS5x32\0\0\0\0\0\rF13Rawhidex64\0\0\0\0\0\0\16TmpDebFirewall\0\0\0\0\0\rF12x64preview\0\0\0\0\0\0\nWin2003x32\0\0\0\0\0\7VSphere\0\0\0\0\vWindows7x32\0\0\0\0\vWindows7x64\0\0\0\0\vFreeBSD8x64\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", 356, 0, NULL, NULL) = 356 18952 write(2, "libvir: Remote error : no call waiting for reply with serial 1615\n", 66) = 66 18952 write(1, "\33[26;1H\33[2J\33[?47l\0338\r\33[?1l\33>", 27) = 27 18952 ioctl(1, SNDCTL_TMR_STOP or TCSETSW, {B9600 opost isig icanon echo ...}) = 0 18952 write(2, "libvirt: VIR_ERR_RPC: VIR_FROM_REMOTE: no call waiting for reply with serial 1615\n", 82) = 82 18952 exit_group(1) = ?
--- Additional comment from rjones@redhat.com on 2010-02-24 07:07:43 EST ---
Created an attachment (id=396047) --> (https://bugzilla.redhat.com/attachment.cgi?id=396047) strace from Rawhide libvirt / Rawhide virt-top
Full strace output, requested by danpb.
--- Additional comment from rjones@redhat.com on 2010-02-24 08:08:57 EST ---
Patch posted upstream (libvirt) to fix this:
https://www.redhat.com/archives/libvir-list/2010-February/msg00824.html
--- Additional comment from rjones@redhat.com on 2010-02-24 12:33:09 EST ---
This change was pushed to upstream libvirt which fixes the bug:
http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=f4a43df52b7c84bda618632...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
--- Comment #1 from Richard W.M. Jones rjones@redhat.com 2010-02-24 17:41:11 EST --- I don't know if we're planning a rebase of libvirt which will get this fix for free. But if not, then we really do need this fix to be in RHEL 6, since it manifests as an annoying and obvious bug in virt-top.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
--- Comment #2 from RHEL Product and Program Management pm-rhel@redhat.com 2010-02-24 17:59:52 EST --- This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux major release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Major release. This request is not yet committed for inclusion.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
Daniel Berrange berrange@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
--- Comment #3 from Daniel Berrange berrange@redhat.com 2010-03-16 13:00:48 EDT --- This was included in last rebase to 0.7.8 tree
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
Suzanne Yeghiayan syeghiay@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |syeghiay@redhat.com Fixed In Version| |libvirt-0.7.8.el6
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
Dennis Gregorovic dgregor@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dgregor@redhat.com Fixed In Version|libvirt-0.7.8.el6 |libvirt-0.7.8-1
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
Lawrence Lim llim@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |llim@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
Osier Yang jyang@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |VERIFIED CC| |jyang@redhat.com
--- Comment #6 from Osier Yang jyang@redhat.com 2010-06-28 05:39:20 EDT --- verified on:
[root@dhcp-66-65-163 libguestfs]# rpm -q libvirt libvirt-0.8.1-9.el6.x86_64 [root@dhcp-66-65-163 libguestfs]# rpm -q virt-top virt-top-1.0.4-3.1.el6.x86_64
tried many times, no abnormal exits.
- Osier
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
Wayne Sun gsun@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|VERIFIED |ASSIGNED CC| |gsun@redhat.com
--- Comment #7 from Wayne Sun gsun@redhat.com 2010-09-15 01:08:15 EDT --- When resize the window from right side to left or reverse, while reach to the minimum size, the command will exit. But did not get error info in strace. So there still have problem, move to Assigned.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
--- Comment #8 from Wayne Sun gsun@redhat.com 2010-09-15 01:10:13 EDT --- Created attachment 447384 --> https://bugzilla.redhat.com/attachment.cgi?id=447384 Strace log
Build: RC3 20100909.1 # rpm -q virt-top libvirt virt-top-1.0.4-3.1.el6.x86_64 libvirt-0.8.1-27.el6.x86_64
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
--- Comment #9 from Richard W.M. Jones rjones@redhat.com 2010-09-15 02:27:10 EDT --- (In reply to comment #7)
When resize the window from right side to left or reverse, while reach to the minimum size, the command will exit. But did not get error info in strace. So there still have problem, move to Assigned.
Might be because the window is too small. I think there is a test for that which may cause it to exit. Thanks for looking at this, I'll need to investigate this further.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
Denise Dumas ddumas@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ddumas@redhat.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
Daniel Berrange berrange@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA
--- Comment #11 from Daniel Berrange berrange@redhat.com 2010-09-15 10:04:00 EDT --- This bug was tracking the original problem which is that libvirt didn't mask signals correctly. The problem Wayne Sun reports in comment #8 sounds like a different problem, which just happens to have the same user visible results. Since virt-top is a separate component, it will need a separate BZ filed, since this BZ is for libvirt. Thus I'm putting this bug back to ON_QA.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
Daniel Berrange berrange@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|virt-top exits sometimes |libvirt does not block |when the window is resized |signals, causing virt-top | |to fail when getting | |sigwinch from a terminal | |resize
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
Wayne Sun gsun@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(berrange@redhat.c | |om)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
Daniel Berrange berrange@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(berrange@redhat.c | |om) |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=568172
Johnny Liu jialiu@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |VERIFIED CC| |jialiu@redhat.com
--- Comment #16 from Johnny Liu jialiu@redhat.com 2010-09-29 05:50:37 EDT --- Verified the defect with libvirt-0.8.1-27.el6.x86_64, and PASSED.
libvirt-0.8.1-27.el6.x86_64 virt-top-1.0.4-3.1.el6.x86_64
Tried many times, no abnormal exits.
ocaml-devel@lists.fedoraproject.org