On Tue, Oct 05, 2021 at 02:14:34PM -0600, Jerry James wrote:
On Tue, Oct 5, 2021 at 1:35 PM Richard W.M. Jones
<rjones(a)redhat.com> wrote:
> I think we're done now. I will issue the Bodhi update in a few minutes.
Great! Thanks for doing all that work.
> - Some packages using dune now require that ocaml-result-devel is
> installed at runtime (but it's not pulled in by default). I don't
> know exactly why, but see for example:
>
https://src.fedoraproject.org/rpms/ocaml-parmap/c/ff9d11b089d8f43fa26d88d...
Ah, yes, dune-configurator requires result. From dune-configurator.opam:
depends: [
"dune" {>= "2.9"}
"ocaml" {>= "4.03.0"}
"result"
"csexp" {>= "1.3.0"}
"odoc" {with-doc}
]
Most packages don't need dune-configurator. Those that do BR:
ocaml-dune-devel instead of just ocam-dune. Thoughts on how to
address this:
- Leave things the way they are, since you already worked around the issue.
- Add "Requires: ocaml-result-devel%{?_isa}" to the ocaml-dune-devel
package. The result package needs dune to build, but it doesn't need
dune-configurator, so that will *probably* work.
- Patch dune to remove the need for ocaml-result. That package is
trivial for OCaml >= 4.03, so we could patch it to just use the
standard library Result type. I used to do that for ocaml-csexp,
which is needed to build dune, until upstream released a version
without a dependency on result.
I'm not sure which is best. It's fixed at the moment though so I
guess we can leave it and see if more packages need this in future.
Rich.
> - Coq and related packages seemed to build fine on s390x.
That is excellent news.
> I believe that all packages got rebuilt in the end, but I had to hack
> a few, especially
>
https://src.fedoraproject.org/rpms/ocaml-merlin/commits/rawhide
> I have also filed a few bugs upstream. See comments in individual
> packages.
Wow, sorry you had to deal with that. I'll keep an eye on merlin upstream.
> Overall it's not the worst but also not the best OCaml upgrade that
> I've done.
Thanks again!
--
Jerry James
http://www.jamezone.org/
--
Richard Jones, Virtualization Group, Red Hat
http://people.redhat.com/~rjones
Read my programming and virtualization blog:
http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW